qiskit: Pulse, ParametricPulse and SamplePulse types should not live in pulse_lib
What is the expected enhancement?
These are all types within our IR and should not live within an implementation library (they currently are in pulse_lib). They probably should live in a module qiskit.pulse.types
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Comments: 28 (28 by maintainers)
Ok, so instead of a types dir, there would be a new types module in pulse that would now contain the 3 classes. When you say the implementations could stay in pulse_lib, are you saying that for example, the class Gaussian and others would stay in parametric_pulses.py in pulse_lib. But pulse.py and sample_pulse.py would go away since they only contain the base classes? If there’s agreement on structure, I can get started on this and then dig into the docs to see what changes are needed there.