Diamond: diamond is not py3k ready

python3 setup.py build works fine but then running the result:

$ PYTHONPATH=build/lib/ python3 build/scripts-3.5/diamond
  File "build/scripts-3.5/diamond", line 112
    print "Diamond version %s" % (get_diamond_version())
                             ^
SyntaxError: invalid syntax

this is likely just the tip of the iceberg, and there is more work to do to make diamond really py3k ready

About this issue

Original URL
State: open
Created 8 years ago
Comments: 19 (12 by maintainers)

Most upvoted comments

Python 2.7 is now EOL as well. I’m not sure if Diamond is even still maintained, but it seems like if this project is going to continue than py3 support is pretty much a necessity…

jantman on Jan 5, 2020

python 2.5/2.6 are dead, so keeping their compatibility (and doing so preventing “progress”) seems the wrong way for a python project.

other than then usual boilerplate of the advantage of py3k, it is anyway the future of the language and a huge amount of work has been done to allow developers to write code that could be executed -without any change- both in 2.7 and 3.3+

There might be also people that would like to only run python3 on their machine (Arch switched /usr/bin/python to python3 long time ago), and given it’s possible to extend with additional collectors, those might be easier written with a py3k-friendly syntax and/or you could gather more collaborations not closing that door in the code.

I wont use expressions like “0 value”/ no value, as it is discouraging and shortsighted.

thanks anyway for your attention

sandrotosi on Feb 15, 2016

This is really annoying. I can’t find a single demo of this project. Not a screenshot. The first thing I run into when I finally decide to install it just to learn about it… is this. An insistence on not supporting Python 3 so that they can support 2.5. The reason we keep quoting Gretzky is because people still don’t get it. “I skate to where the puck is going to be, not to where it has been.” http://www.macleans.ca/economy/business/why-business-people-wont-stop-using-that-gretzky-quote/

RichardBronosky on Nov 20, 2016

@hugovk done!

josegonzalez on Mar 15, 2018

@mattrobenolt 💯 I’d definitely immediately look at anyone’s pull request to add Python3 support, while at least supporting Python 2.7 (which is where I currently deploy on Ubuntu 14.04). One minor blocker is getting as many bug fixes merged into the existing collectors, and then moving them out to their own projects, which should ease the upgrade burden. We’ll still need to figure out packaging - debs, rpms, etc. - but thats a separate issue entirely.

We can make a major release as soon as that is the case.

josegonzalez on Nov 25, 2016