pytest: resolve startpath/fspath parameter regressions
the introductin of various startpath
/fspath
hooks in the hookspecs
as a non-optional and non-inmplied parameter is practically a api breaking change
back in 2018 i decoded to close the upstream issue in https://github.com/pytest-dev/pluggy/issues/15 as its pretty much insanely complex to alter the hooks where callers and callees are not under good control
the pr adding them is #8144
CC @bluetech
i believe/fear the correct solution would be to deprecate the old hook names, introduce a new hook version and have invoking/implementing the old one trigger a deprecation warning
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 20 (20 by maintainers)
Commits related to this issue
- address #8361 - introduce hook caller wrappers that enable backward compat — committed to RonnyPfannschmidt/pytest by RonnyPfannschmidt 3 years ago
- fix #8361: address review/quality comments — committed to RonnyPfannschmidt/pytest by RonnyPfannschmidt 3 years ago
- Merge pull request #8463 from RonnyPfannschmidt/workaround-8361 address #8361 - introduce hook caller wrappers that enable backward compat — committed to pytest-dev/pytest by RonnyPfannschmidt 3 years ago
@bluetech @nicoddemus i have an idea for a potential solution,
im wireing up a POC now that will get us backward-compatibility