pytest: doc: pytest_ignore_collect: wrong signature
It says to provide a string, but (at least in some place) is a py.path.local
.
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Comments: 20 (20 by maintainers)
Commits related to this issue
- Merge #69 69: Update pytest to 4.4.2 r=rehandalal a=pyup-bot This PR updates [pytest](https://pypi.org/project/pytest) from **4.4.1** to **4.4.2**. <details> <summary>Changelog</summary> ... — committed to rehandalal/therapist by bors[bot] 5 years ago
- Merge #1887 1887: Scheduled weekly dependency update for week 19 r=rehandalal a=pyup-bot ### Update [botocore](https://pypi.org/project/botocore) from **1.12.142** to **1.12.146**. <details> ... — committed to mozilla/normandy by bors[bot] 5 years ago
- Merge #32 32: Pin pytest to latest version 5.1.3 r=duckinator a=pyup-bot This PR pins [pytest](https://pypi.org/project/pytest) to the latest release **5.1.3**. <details> <summary>Changelog</s... — committed to duckinator/bork by bors[bot] 5 years ago
- Merge #1 1: Initial Update r=aragilar a=pyup-bot This PR sets up pyup.io on this repo and updates all dependencies at once, in a single branch. Subsequent pull requests will update one dependency... — committed to aragilar/pytest-info-collector by bors[bot] 4 years ago
- Merge #1 1: Initial Update r=aragilar a=pyup-bot This PR sets up pyup.io on this repo and updates all dependencies at once, in a single branch. Subsequent pull requests will update one dependency... — committed to aragilar/spaceplot by bors[bot] 4 years ago
- Merge #1 1: Initial Update r=aragilar a=pyup-bot This PR sets up pyup.io on this repo and updates all dependencies at once, in a single branch. Subsequent pull requests will update one dependency... — committed to aragilar/venv_tools by bors[bot] 4 years ago
- Merge #5 5: Initial Update r=aragilar a=pyup-bot This PR sets up pyup.io on this repo and updates all dependencies at once, in a single branch. Subsequent pull requests will update one dependency... — committed to aragilar/root-solver by bors[bot] 4 years ago
I haven’t checked the details, just reported it - otherwise it would have been a PR already… 😉 Sorry for not being clear, but that was what I’ve implied with “at least in some place”.
OK, took the time to review this. In the case of
pytest_ignore_collect
, every call that I can see in pytest passes apy.local.path
instance. So forpytest_ignore_collect
, it is clear we should only update the docstring, as every call is getting apy.local.path
.Checked
pytest_collect_directory
,pytest_collect_file
, andpytest_pycollect_makemodule
: same thing, we always pass apy.local.path
instance.So in the end, sorry about the confusion, I misunderstood the issue.
@DamianSkrzypczak: in summary, we just need to update the docstring of those hooks to state that they receive
py.local.path
objects, and notstr
objects as stated in the docs.@DamianSkrzypczak Yes, go ahead… 😃