pip: Don't expect so many failures
I can only guess that test_basic.py has so many expect_failure=True’s out of a desire to be resilient if the testing environment doesn’t have tools like SVN installed. Really, if there’s a failure in [[http://bitbucket.org/ianb/pip/src/tip/tests/test_basic.py#cl-50|the SVN command]], though, it’s unlikely that any of the following lines will pass. As it is, the instruction to skip looks like at best obfuscation and at worse something that could cause a real problem to slip by undetected. The right answer is probably to use a mechanism to skip tests with dependencies that aren’t installed (and have a mode where everything is run anyway so we can find out what’s needed)
- Bitbucket: https://bitbucket.org/ianb/pip/issue/102
- Originally Reported By: Dave Abrahams
- Originally Created At: 2010-04-28 20:37:31
About this issue
- Original URL
- State: closed
- Created 13 years ago
- Comments: 15 (14 by maintainers)
All over the place there are tests that call
script.pip(or similar) that have anexpect_error=Trueorexpect_stderr=Truethat don’t need it. The way to resolve this ticket is for someone to go through and remove any of those that are not needed for the tests to pass.The
easy fixpart I had in mind was to check wheither the tests were in fact passing but I don’t think we have any test unexpectedly passing. So nevermind theeasy fix^^