pwndbg: Incorrect OS handling in setup.sh script

Description

uname command returns ‘Linux’ in Arch Linux environment, so the setup script tries to use apt-get package manager. However, Arch Linux does not have apt-get command and installation fails.

image

About this issue

  • Original URL
  • State: closed
  • Created 7 years ago
  • Comments: 16 (7 by maintainers)

Commits related to this issue

Most upvoted comments

I think an acceptable middle ground would be to have an INSTALL.md or similar that we can use for Ubuntu and non-Ubuntu setup instructions (eg to instruct Arch users the correct command to use to get pwndbg-git from AUR).

We can link to INSTALL.md from README.md so web users can find it.

Additionally, we can have a check for apt-get, and if it is missing, we can direct the user to look at INSTALL.md. On Tue, Jun 27, 2017 at 4:17 PM Levente Polyak notifications@github.com wrote:

I personally don’t think it’s a good idea to maintain all distro package managers and theirs package names at upstream. It’s a waste of efforts and a never ending story of changes, adjustments and missing dependencies plus annoyance when adding new dependencies.

Such things should be handled per. Distro by the distro. For example, if you want to use it for Arch Linux simply use the pwndbg or pwndbg-git package from the AUR.

I already went through a project that tried to do this, it ended up in a total mess and exactly the scenarios mentioned above.

Just my 2 cents

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pwndbg/pwndbg/issues/296#issuecomment-311488342, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG0GKkDa8O0t0zYC8jw44ZUYXFGxvGfks5sIXGAgaJpZM4N9Fqy .

guys, the way how you “support” OS installation is wrong. It should be platform independent and should definitely exclude sudo <pkg manager> install or any other sudo commands. Please convert it to a proper setup.py using distutils.
Here is a nice example (but not complete, they haven’t added requirements.txt yet) of the recent wifite migration: https://github.com/derv82/wifite2/issues/102