pwndbg: Incorrect OS handling in setup.sh script
Description
uname
command returns ‘Linux’ in Arch Linux environment, so the setup script tries to use apt-get
package manager. However, Arch Linux does not have apt-get
command and installation fails.
About this issue
- Original URL
- State: closed
- Created 7 years ago
- Comments: 16 (7 by maintainers)
Commits related to this issue
- Add the installation script for each distros. This commit adds the installation script for each distros in setup.sh. Also, the content of the script was changed to install all the required packages ... — committed to claudiajkang/pwndbg by claudiajkang 6 years ago
- Added the installation script for each distros. This commit adds the installation script for each distros in setup.sh. Also, the content of the script was changed to install all the required package... — committed to claudiajkang/pwndbg by claudiajkang 6 years ago
- Added the installation script for each distros. This commit adds the installation script for each distros in setup.sh. Also, the content of the script was changed to install all the required package... — committed to claudiajkang/pwndbg by claudiajkang 6 years ago
- Added the installation script for each distros. This commit adds the installation script for each distros in setup.sh. Also, the content of the script was changed to install all the required package... — committed to claudiajkang/pwndbg by claudiajkang 6 years ago
- Added the installation script for each distros. (#540) * Added the installation script for each distros. This commit adds the installation script for each distros in setup.sh. Also, the content... — committed to pwndbg/pwndbg by claudiajkang 6 years ago
I think an acceptable middle ground would be to have an INSTALL.md or similar that we can use for Ubuntu and non-Ubuntu setup instructions (eg to instruct Arch users the correct command to use to get pwndbg-git from AUR).
We can link to INSTALL.md from README.md so web users can find it.
Additionally, we can have a check for apt-get, and if it is missing, we can direct the user to look at INSTALL.md. On Tue, Jun 27, 2017 at 4:17 PM Levente Polyak notifications@github.com wrote:
guys, the way how you “support” OS installation is wrong. It should be platform independent and should definitely exclude
sudo <pkg manager> install
or any other sudo commands. Please convert it to a proper setup.py using distutils.Here is a nice example (but not complete, they haven’t added requirements.txt yet) of the recent wifite migration: https://github.com/derv82/wifite2/issues/102