puma: Conditional port is ignored in puma.rb

When I put a conditional for the port value it seems to get ignored and 5000 is used. When I define the port explicitly it works. Here is my puma.rb, the ENV['PORT'] is not defined in this case, running locally.

When I do port 3001 it works.

Using Puma 3.0.2

workers Integer(ENV['WEB_CONCURRENCY'] || 2)
threads_count = Integer(ENV['MAX_THREADS'] || 5)
threads threads_count, threads_count

preload_app!

rackup      DefaultRackup
port        ENV['PORT'] || 3001
environment ENV['RACK_ENV'] || 'development'

on_worker_boot do
  # Worker specific setup for Rails 4.1+
  # See: https://devcenter.heroku.com/articles/deploying-rails-applications-with-the-puma-web-server#on-worker-boot
  ActiveRecord::Base.establish_connection

  if defined?(Resque)
     Resque.redis = ENV["<redis-uri>"] || "redis://127.0.0.1:6379"
  end

end

About this issue

Original URL
State: closed
Created 8 years ago
Reactions: 1
Comments: 20 (15 by maintainers)

Commits related to this issue

Reverse the order of fetching data from config to make puma config is source of truth and return value from it first, if present Fixes #939 — committed to vipulnsward/puma by vipulnsward 8 years ago
[webui] Run puma on port 3000 in dev After we switched from unicorn to puma in #5284, the rails development server started to run on port 5000. This is caused by foreman as it sets the environment v... — committed to ChrisBr/open-build-service by ChrisBr 6 years ago

Most upvoted comments

hey @omitter we’re fixing this via https://github.com/rails/rails/pull/28137

nateberkopec on Feb 27, 2017

This works for me

$ env PORT=4000 rails server
=> Booting Puma
=> Rails 5.0.0.beta3 application starting in development on http://localhost:4000
=> Run `rails server -h` for more startup options
=> Ctrl-C to shutdown server
/Users/richardschneeman/Documents/projects/codetriage/config/initializers/git_hub_bub.rb:2: warning: already initialized constant GitHubBub::Request::USER_AGENT
/Users/richardschneeman/.gem/ruby/2.3.0/gems/git_hub_bub-0.0.6/lib/git_hub_bub/request.rb:7: warning: previous definition of USER_AGENT was here
/Users/richardschneeman/Documents/projects/codetriage/config/initializers/git_hub_bub.rb:3: warning: already initialized constant GitHubBub::Request::RETRIES
/Users/richardschneeman/.gem/ruby/2.3.0/gems/git_hub_bub-0.0.6/lib/git_hub_bub/request.rb:12: warning: previous definition of RETRIES was here
/Users/richardschneeman/Documents/projects/codetriage/config/initializers/git_hub_bub.rb:4: warning: already initialized constant GitHubBub::Request::GITHUB_VERSION
/Users/richardschneeman/.gem/ruby/2.3.0/gems/git_hub_bub-0.0.6/lib/git_hub_bub/request.rb:8: warning: previous definition of GITHUB_VERSION was here
[59980] Puma starting in cluster mode...
[59980] * Version 3.0.0.rc1 (ruby 2.3.0-p0), codename: Schneems Sleak Shoes
[59980] * Min threads: 5, max threads: 5
[59980] * Environment: development
[59980] * Process workers: 2
[59980] * Preloading application
[59980] * Listening on tcp://localhost:4000
[59980] Use Ctrl-C to stop
[59980] - Worker 0 (pid: 60018) booted, phase: 0
[59980] - Worker 1 (pid: 60019) booted, phase: 0

Are you using Puma 3.0 or above?

schneems on Apr 7, 2016

Related https://github.com/rails/rails/issues/24435#issuecomment-205875323 rails server, does not support it. running puma directly will.

vipulnsward on Apr 5, 2016

{:env=>nil}

workers Integer(ENV['WEB_CONCURRENCY'] || 2)
threads_count = Integer(ENV['MAX_THREADS'] || 5)
threads threads_count, threads_count

preload_app!

rackup      DefaultRackup
p :env => ENV['port']
port        ENV['PORT'] || 3001
environment ENV['RACK_ENV'] || 'development'

on_worker_boot do
  # Worker specific setup for Rails 4.1+
  # See: https://devcenter.heroku.com/articles/deploying-rails-applications-with-the-puma-web-server#on-worker-boot


end

It seemed to be working for a while, is the port cached somewhere and it’s not getting reset upon start/stop of server?

micahlisonbee on Apr 5, 2016