octicons: [Feedback] npm package contains duplicate icon data

Describe the topic

I just installed v16.1.1 of @primer/octicons and noticed the svg folder and data.json file are duplicated in the package. I don’t think this is intended and it’s doubling the size of the package.

image

About this issue

  • Original URL
  • State: closed
  • Created 3 years ago
  • Reactions: 2
  • Comments: 16 (16 by maintainers)

Most upvoted comments

Indeed in my link you can see the package going from 2.16 to 1.08, exactly half

Just wanted to confirm that I don’t see this anymore in v19.9.0. Going to close this out as I believe it’s been addressed, feel free to leave a comment if I’m getting something wrong here!

Thanks @fregante! ✨ We might be a little slower than usual with PR review due to the holiday season, but we should be able to get to it in the new year. Thanks for contibuting!

I think this is still an issue. I believe both data sources are in use, so we’d need to investigate which one we can remove and update any libraries using them.