primefaces: Checkbox: Regression, custom styling of checkbox active state no longer working

Describe the defect The custom styling for a checkbox actiove state is no longer working. I am no CSS expert, but I had to add an additional attribute selector to bring it back into working order.

Reproducer n/a

Environment:

  • PF Version: 10.0 Snapshot
  • JSF + version: _e.g. Mojarra 2.3.9
  • Affected browsers: e.g. Chrome, iOS, ALL

To Reproduce

Expected behavior

// PF 8.0

.ui-chkbox-box.ui-state-active {
    border-color: #007ad9;
    background-color: #007ad9;
    color: #000;
}

// PF 10.0

.ui-chkbox-box.ui-state-active, .ui-chkbox-box[aria-checked='true'] {
    border-color: #007ad9;
    background-color: #007ad9;
    color: #000;
}

About this issue

  • Original URL
  • State: closed
  • Created 3 years ago
  • Comments: 23 (20 by maintainers)

Commits related to this issue

Most upvoted comments

it should be different when selected and selected+focus. Same background, but focus should highlight it with another border. This makes 3 different selectors: .ui-state-focus .ui-state-active .ui-state-active.ui-state-focus