primefaces-extensions: OrgChart: FontAwesome icons no longer work
@jxmai your recent changes prevent FontAwesome icons from working in the OrgChart.
In our showcase parentNodeSymbol="fa-folder-open" now does nothing.
About this issue
- Original URL
- State: open
- Created a year ago
- Reactions: 1
- Comments: 15 (15 by maintainers)
Commits related to this issue
- Fix #1050 - Orgchart: FontAwesome icons no longer work (use orgchart provided customized icons) — committed to jxmai/primefaces-extensions by jxmai a year ago
- Fix #1050 - Orgchart: FontAwesome icons no longer work (use orgchart provided customized icons) (#1051) — committed to Rapster/core by jxmai a year ago
Agreed
It also looks like they have a new version 3.4.0 out. It might be we need to somehow override their font with font-awesome hopefully they have some guidance on how to override their icons with custom icons?
I see. Let me self-assign this ticket and I will review this one.
From their website,
https://dabeng.github.io/OrgChart/default-collapsed.html
I can see the newly introduced oci
based on the comments, it says custom icons indeed
and there’s some commits in orgchart repo to remove the font-awesome dependency
https://github.com/dabeng/OrgChart/commit/f44deb8d801bbb58f2f024c456330e805814f0d9
and refactor the demo:
https://github.com/dabeng/OrgChart/commit/571fc97269493861867efe6b3ef3edf7f1fd8cc2
My initial impression is that font-awesome dependency is removed and they introduce their own icon indeed, but the question is that why it is not showing up in our demo that needs to be investigated.