prettier: Warning for a breakign change for 2.0.1 missing - text.trimEnd is not a function

Environments:

Prettier Version: 2.0.1
Running Prettier via: CLI
Runtime: Node
Operating System: macOS

Steps to reproduce: Try to format a file that we have and was successfully format for months

Expected behavior: File is formated

Actual behavior:

Checking formatting...
app/assets/javascripts/ext/project/abstract_tree_viewer.js
[error] app/assets/javascripts/ext/project/abstract_tree_viewer.js: TypeError: text.trimEnd is not a function
[error]     at attachComments (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14775:60)
[error]     at coreFormat (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14802:23)
[error]     at format (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15024:75)
[error]     at formatWithCursor (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15040:12)
[error]     at Object.args [as formatWithCursor] (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:50647:12)
[error]     at format$1 (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52692:19)
[error]     at Object.formatFiles (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52865:16)
[error]     at Object.run (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53319:14)
[error]     at Object.<anonymous> (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53334:5)
[error]     at Module._compile (module.js:653:30)
app/assets/javascripts/ext/project/fancytree/dependencies.js
[error] app/assets/javascripts/ext/project/fancytree/dependencies.js: TypeError: text.trimEnd is not a function
[error]     at attachComments (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14775:60)
[error]     at coreFormat (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14802:23)
[error]     at format (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15024:75)
[error]     at formatWithCursor (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15040:12)
[error]     at Object.args [as formatWithCursor] (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:50647:12)
[error]     at format$1 (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52692:19)
[error]     at Object.formatFiles (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52865:16)
[error]     at Object.run (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53319:14)
[error]     at Object.<anonymous> (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53334:5)
[error]     at Module._compile (module.js:653:30)
app/assets/javascripts/ext/project/fancytree/fancytree_editor.js
[error] app/assets/javascripts/ext/project/fancytree/fancytree_editor.js: TypeError: text.trimEnd is not a function
[error]     at attachComments (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14775:60)
[error]     at coreFormat (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14802:23)
[error]     at format (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15024:75)
[error]     at formatWithCursor (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15040:12)
[error]     at Object.args [as formatWithCursor] (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:50647:12)
[error]     at format$1 (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52692:19)
[error]     at Object.formatFiles (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52865:16)
[error]     at Object.run (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53319:14)
[error]     at Object.<anonymous> (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53334:5)
[error]     at Module._compile (module.js:653:30)
app/assets/javascripts/ext/project/fancytree/fancytree_filtered_steps_styler.js
[error] app/assets/javascripts/ext/project/fancytree/fancytree_filtered_steps_styler.js: TypeError: text.trimEnd is not a function
[error]     at attachComments (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14775:60)
[error]     at coreFormat (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14802:23)
[error]     at format (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15024:75)
[error]     at formatWithCursor (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15040:12)
[error]     at Object.args [as formatWithCursor] (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:50647:12)
[error]     at format$1 (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52692:19)
[error]     at Object.formatFiles (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52865:16)
[error]     at Object.run (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53319:14)
[error]     at Object.<anonymous> (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53334:5)
[error]     at Module._compile (module.js:653:30)
app/assets/javascripts/ext/project/fancytree/fancytree_viewer.js
[error] app/assets/javascripts/ext/project/fancytree/fancytree_viewer.js: TypeError: text.trimEnd is not a function
[error]     at attachComments (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14775:60)
[error]     at coreFormat (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14802:23)
[error]     at format (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15024:75)
[error]     at formatWithCursor (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15040:12)
[error]     at Object.args [as formatWithCursor] (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:50647:12)
[error]     at format$1 (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52692:19)
[error]     at Object.formatFiles (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52865:16)
[error]     at Object.run (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53319:14)
[error]     at Object.<anonymous> (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53334:5)
[error]     at Module._compile (module.js:653:30)
app/assets/javascripts/ext/project/fancytree/i_fancytree_extension.js
[error] app/assets/javascripts/ext/project/fancytree/i_fancytree_extension.js: TypeError: text.trimEnd is not a function
[error]     at attachComments (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14775:60)
[error]     at coreFormat (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14802:23)
[error]     at format (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15024:75)
[error]     at formatWithCursor (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15040:12)
[error]     at Object.args [as formatWithCursor] (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:50647:12)
[error]     at format$1 (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52692:19)
[error]     at Object.formatFiles (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52865:16)
[error]     at Object.run (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53319:14)
[error]     at Object.<anonymous> (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53334:5)
[error]     at Module._compile (module.js:653:30)
app/assets/javascripts/ext/project/fancytree/i_fancytree_steps_styler.js
[error] app/assets/javascripts/ext/project/fancytree/i_fancytree_steps_styler.js: TypeError: text.trimEnd is not a function
[error]     at attachComments (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14775:60)
[error]     at coreFormat (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14802:23)
[error]     at format (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15024:75)
[error]     at formatWithCursor (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15040:12)
[error]     at Object.args [as formatWithCursor] (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:50647:12)
[error]     at format$1 (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52692:19)
[error]     at Object.formatFiles (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52865:16)
[error]     at Object.run (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53319:14)
[error]     at Object.<anonymous> (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53334:5)
[error]     at Module._compile (module.js:653:30)
app/assets/javascripts/ext/project/register_fancytree_filtered_steps_styler.js
[error] app/assets/javascripts/ext/project/register_fancytree_filtered_steps_styler.js: TypeError: text.trimEnd is not a function
[error]     at attachComments (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14775:60)
[error]     at coreFormat (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14802:23)
[error]     at format (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15024:75)
[error]     at formatWithCursor (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15040:12)
[error]     at Object.args [as formatWithCursor] (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:50647:12)
[error]     at format$1 (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52692:19)
[error]     at Object.formatFiles (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52865:16)
[error]     at Object.run (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53319:14)
[error]     at Object.<anonymous> (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53334:5)
[error]     at Module._compile (module.js:653:30)
app/assets/javascripts/ext/project/register_tree_editor.js
[error] app/assets/javascripts/ext/project/register_tree_editor.js: TypeError: text.trimEnd is not a function
[error]     at attachComments (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14775:60)
[error]     at coreFormat (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14802:23)
[error]     at format (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15024:75)
[error]     at formatWithCursor (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15040:12)
[error]     at Object.args [as formatWithCursor] (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:50647:12)
[error]     at format$1 (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52692:19)
[error]     at Object.formatFiles (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52865:16)
[error]     at Object.run (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53319:14)
[error]     at Object.<anonymous> (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53334:5)
[error]     at Module._compile (module.js:653:30)
app/assets/javascripts/ext/project/register_tree_viewer.js
[error] app/assets/javascripts/ext/project/register_tree_viewer.js: TypeError: text.trimEnd is not a function
[error]     at attachComments (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14775:60)
[error]     at coreFormat (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14802:23)
[error]     at format (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15024:75)
[error]     at formatWithCursor (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15040:12)
[error]     at Object.args [as formatWithCursor] (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:50647:12)
[error]     at format$1 (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52692:19)
[error]     at Object.formatFiles (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52865:16)
[error]     at Object.run (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53319:14)
[error]     at Object.<anonymous> (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53334:5)
[error]     at Module._compile (module.js:653:30)
app/assets/javascripts/ext/project/tree_explorer.js
[error] app/assets/javascripts/ext/project/tree_explorer.js: TypeError: text.trimEnd is not a function
[error]     at attachComments (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14775:60)
[error]     at coreFormat (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14802:23)
[error]     at format (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15024:75)
[error]     at formatWithCursor (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15040:12)
[error]     at Object.args [as formatWithCursor] (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:50647:12)
[error]     at format$1 (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52692:19)
[error]     at Object.formatFiles (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52865:16)
[error]     at Object.run (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53319:14)
[error]     at Object.<anonymous> (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53334:5)
[error]     at Module._compile (module.js:653:30)
test/dummy/spec/javascripts/ext/project/abstract_tree_viewer_spec.js
[error] test/dummy/spec/javascripts/ext/project/abstract_tree_viewer_spec.js: TypeError: text.trimEnd is not a function
[error]     at attachComments (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14775:60)
[error]     at coreFormat (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14802:23)
[error]     at format (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15024:75)
[error]     at formatWithCursor (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15040:12)
[error]     at Object.args [as formatWithCursor] (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:50647:12)
[error]     at format$1 (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52692:19)
[error]     at Object.formatFiles (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52865:16)
[error]     at Object.run (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53319:14)
[error]     at Object.<anonymous> (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53334:5)
[error]     at Module._compile (module.js:653:30)
test/dummy/spec/javascripts/ext/project/fancytree/fancytree_editor_spec.js
[error] test/dummy/spec/javascripts/ext/project/fancytree/fancytree_editor_spec.js: TypeError: text.trimEnd is not a function
[error]     at attachComments (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14775:60)
[error]     at coreFormat (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14802:23)
[error]     at format (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15024:75)
[error]     at formatWithCursor (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15040:12)
[error]     at Object.args [as formatWithCursor] (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:50647:12)
[error]     at format$1 (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52692:19)
[error]     at Object.formatFiles (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52865:16)
[error]     at Object.run (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53319:14)
[error]     at Object.<anonymous> (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53334:5)
[error]     at Module._compile (module.js:653:30)
test/dummy/spec/javascripts/ext/project/fancytree/fancytree_filtered_steps_styler_spec.js
[error] test/dummy/spec/javascripts/ext/project/fancytree/fancytree_filtered_steps_styler_spec.js: TypeError: text.trimEnd is not a function
[error]     at attachComments (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14775:60)
[error]     at coreFormat (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14802:23)
[error]     at format (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15024:75)
[error]     at formatWithCursor (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15040:12)
[error]     at Object.args [as formatWithCursor] (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:50647:12)
[error]     at format$1 (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52692:19)
[error]     at Object.formatFiles (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52865:16)
[error]     at Object.run (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53319:14)
[error]     at Object.<anonymous> (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53334:5)
[error]     at Module._compile (module.js:653:30)
test/dummy/spec/javascripts/ext/project/fancytree/fancytree_viewer_spec.js
[error] test/dummy/spec/javascripts/ext/project/fancytree/fancytree_viewer_spec.js: TypeError: text.trimEnd is not a function
[error]     at attachComments (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14775:60)
[error]     at coreFormat (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14802:23)
[error]     at format (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15024:75)
[error]     at formatWithCursor (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15040:12)
[error]     at Object.args [as formatWithCursor] (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:50647:12)
[error]     at format$1 (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52692:19)
[error]     at Object.formatFiles (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52865:16)
[error]     at Object.run (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53319:14)
[error]     at Object.<anonymous> (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53334:5)
[error]     at Module._compile (module.js:653:30)
vendor/assets/javascripts/gcc/externs/fancytree.externs.js
[error] vendor/assets/javascripts/gcc/externs/fancytree.externs.js: TypeError: text.trimEnd is not a function
[error]     at attachComments (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14775:60)
[error]     at coreFormat (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:14802:23)
[error]     at format (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15024:75)
[error]     at formatWithCursor (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:15040:12)
[error]     at Object.args [as formatWithCursor] (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:50647:12)
[error]     at format$1 (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52692:19)
[error]     at Object.formatFiles (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:52865:16)
[error]     at Object.run (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53319:14)
[error]     at Object.<anonymous> (/home/shadydealer/.nvm/versions/node/v8.17.0/lib/node_modules/prettier/bin-prettier.js:53334:5)
[error]     at Module._compile (module.js:653:30)
Colla

About this issue

Original URL
State: closed
Created 4 years ago
Reactions: 5
Comments: 18 (7 by maintainers)

Most upvoted comments

@ycjcl868 yes the small differences (like not breaking downstream clients) really could save or lose a few days or each team.

thebravoman on Mar 26, 2020

Thanks for the suggestion @j-f1. It might work for one or two small projects and if there is no CLI infrastructure involved, but it would be a maintenance hell for a real life scenario with more than a few projects.

thebravoman on Mar 26, 2020

I have not blindly updated. All I am doing is npx prettier.

How is this not blindly updating?

Now why has this done an upgrade I can not answer. I don’t know.

That’s how npx works. You should have pinned the version: npx prettier@1.19.1 ...

thorn0 on Mar 22, 2020

@thorn0 I am sorry. I don’t mean to offend you. I have great respect to your work. Guess I go used to getting notifications for deprecations and this got me by surprise. I also did not expected it to come from prettier. Was not prepared for this. Github says it is used by 1.5M, it is the last and final step in our build procedure and I was pretty happy of how we used it. I was expecting other projects in the pipeline to fail, but I had the feeling that prettier was pretty solid.

I have not blindly updated. All I am doing is npx prettier.

Now why has this done an upgrade I can not answer. I don’t know.

I have no problem with upgrading and with braking changes. Please do them. People learn. People become better. It takes practice and it takes experience to keep an API and I am ok with that. I have personally broken changes on API that I have developed and I understand many of the considerations.
All I am asking is for a “note”. A note that says “hey, this will be deprecated.” And to have this note on the build. In a nontrivial stack with many dependencies one can not be expected to constantly monitor all the changes in all the projects. So a good practice I could suggest is to act proactively. Just release a version 1.99 that will mark all the deprecations and give people a chance to migrate with proper messages.
Also document all the features that are no longer supported. A breaking change in my previous bug is actually not mentioned in the breaking changes.

thebravoman on Mar 22, 2020

@thebravoman I really don’t understand your attitude. It’s a major version bump. By definition, you can’t just blindly update to it expecting that nothing will break.

thorn0 on Mar 22, 2020