prettier-vscode: Regression on package.json finding behavior for globally installed prettier with vscode extension

Summary

The prettier vscode extension seems to have had a behavior regression in version 9.16.0. It is no longer able to load the package.json for a globally installed prettier on macOS

Steps To Reproduce:

1. Set prettier path to the globally installed version of prettier, typically: /usr/local/lib/node_modules/prettier on macOS
2. Try to format a file with the “Format document” command

Expected result

The file is formatted with prettier

Actual result

The document is not formatted and the prettier extension throws an error.

Additional information

Behavior works as expected on extension version 9.15.0. Additionally, prettier is present in the path and can be run as expected from the command line.

I have not checked if this behavior regression is also present on Windows or Linux.

EDIT: as per this reply to the issue, it appears to also effect windows

Here’s the ls of the prettier install location ( /usr/local/lib/node_modules/prettier )

➜  ~ ls  /usr/local/lib/node_modules/prettier
LICENSE              parser-angular.js    parser-meriyah.js
README.md            parser-babel.js      parser-postcss.js
bin-prettier.js      parser-espree.js     parser-typescript.js
cli.js               parser-flow.js       parser-yaml.js
doc.js               parser-glimmer.js    standalone.js
esm                  parser-graphql.js    third-party.js
index.js             parser-html.js
package.json         parser-markdown.js

All the correct files appear to be present

VS Code Version:

Version: 1.77.3 Commit: 704ed70d4fd1c6bd6342c436f1ede30d1cff4710 Date: 2023-04-12T09:19:37.325Z (2 mos ago) Electron: 19.1.11 Chromium: 102.0.5005.196 Node.js: 16.14.2 V8: 10.2.154.26-electron.0 OS: Darwin x64 22.3.0 Sandboxed: No

Prettier Extension Version:

v9.16.0

OS and version: macOS Ventura Version 13.2.1 (22D68)

Prettier Log Output

["DEBUG" - 3:22:59 PM] Local prettier module path: '/usr/local/lib/node_modules/prettier'
["INFO" - 3:22:59 PM] Attempted to load Prettier module from /usr/local/lib/node_modules/prettier
["ERROR" - 3:22:59 PM] Failed to load module. If you have prettier or plugins referenced in package.json, ensure you have run `npm install`
["ERROR" - 3:22:59 PM] Cannot find Prettier package.json
Error: Cannot find Prettier package.json
	at t.ModuleResolver.loadPrettierVersionFromPackageJson (/Users/user/.vscode/extensions/esbenp.prettier-vscode-9.16.0/dist/extension.js:1:3693)
	at t.ModuleResolver.getPrettierInstance (/Users/user/.vscode/extensions/esbenp.prettier-vscode-9.16.0/dist/extension.js:1:5087)
	at t.default.handleActiveTextEditorChanged (/Users/user/.vscode/extensions/esbenp.prettier-vscode-9.16.0/dist/extension.js:1:10688)
	at t.default.handleActiveTextEditorChangedSync (/Users/user/.vscode/extensions/esbenp.prettier-vscode-9.16.0/dist/extension.js:1:10290)
	at t.default.registerDisposables (/Users/user/.vscode/extensions/esbenp.prettier-vscode-9.16.0/dist/extension.js:1:13133)
	at /Users/user/.vscode/extensions/esbenp.prettier-vscode-9.16.0/dist/extension.js:1:81225