prettier: Pre-commit is broken when installing
Environments:
- Prettier Version: 2.1.2
- Running Prettier via: pre-commit
- Runtime:
- Operating System: Linux
Steps to reproduce:
- repo: https://github.com/prettier/prettier
rev: 2.1.2
hooks:
- id: prettier
exclude_types: [json]
Expected behavior:
Actual behavior:
An unexpected error has occurred: CalledProcessError: command: ('/home/xuan/.cache/pre-commit/repo88mn0n_k/node_env-default/bin/node', '/home/xuan/.cache/pre-commit/repo88mn0n_k/node_env-default/bin/npm', 'install')
return code: 1
expected return code: 0
stdout: (none)
stderr:
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: prettier@2.1.2
npm ERR! Found: remark-parse@8.0.3
npm ERR! node_modules/remark-parse
npm ERR! remark-parse@"8.0.3" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer remark-parse@"^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0" from remark-math@1.0.6
npm ERR! node_modules/remark-math
npm ERR! remark-math@"1.0.6" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /home/xuan/.npm/eresolve-report.txt for a full report.
npm ERR! A complete log of this run can be found in:
npm ERR! /home/xuan/.npm/_logs/2020-10-20T20_31_29_631Z-debug.log
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Reactions: 12
- Comments: 22 (8 by maintainers)
Commits related to this issue
- Update pre-commit configuration for prettier Related to https://github.com/prettier/prettier/issues/9459 Signed-off-by: Matej Focko <mfocko@redhat.com> — committed to mfocko/ogr by mfocko 4 years ago
- Migrate prettier from prettier/prettier to prettier/pre-commit See https://github.com/prettier/prettier/issues/9459 — committed to Tecnativa/doodba-copier-template by joao-p-marques 4 years ago
- Migrate prettier from prettier/prettier to prettier/pre-commit See https://github.com/prettier/prettier/issues/9459 — committed to Tecnativa/doodba-copier-template by joao-p-marques 4 years ago
- Migrate prettier from prettier/prettier to prettier/pre-commit See https://github.com/prettier/prettier/issues/9459 — committed to Tecnativa/doodba-copier-template by joao-p-marques 4 years ago
- Migrate prettier from prettier/prettier to prettier/pre-commit See https://github.com/prettier/prettier/issues/9459 — committed to Tecnativa/doodba-copier-template by joao-p-marques 4 years ago
- Update prettier hook repo See https://github.com/prettier/prettier/issues/9459 — committed to rkm/pre-commit.com by rkm 4 years ago
- Migrate prettier/prettier to prettier/pre-commit See https://github.com/prettier/prettier/issues/9459 — committed to Tecnativa/oca-addons-repo-template by joao-p-marques 4 years ago
- Change repo for the prettier pre-commit hook Per https://github.com/prettier/prettier/issues/9459 and specifically https://github.com/prettier/prettier/issues/9459#issuecomment-713223710 the prettier... — committed to cisagov/skeleton-generic by mcdonnnj 4 years ago
- Update pre-commit configuration for prettier to fix prettier/prettier#9459 — committed to cisagov/skeleton-tf-module by dav3r 4 years ago
- Pin pre-commit language versions It helps prevent https://github.com/prettier/prettier/issues/9459. — committed to copier-org/autopretty by yajo 4 years ago
- Pin pre-commit language versions It helps prevent https://github.com/prettier/prettier/issues/9459. — committed to copier-org/autopretty by yajo 4 years ago
- Update pre-commit configuration to match changes to prettier See https://github.com/prettier/prettier/issues/9459 for details. Unclear whether this is a prettier bug or an npm bug, but pre-commit fai... — committed to carbon-language/carbon-lang by zygoloid 4 years ago
- Update pre-commit configuration to match changes to prettier (#183) See https://github.com/prettier/prettier/issues/9459 for details. Unclear whether this is a prettier bug or an npm bug, but pre-com... — committed to carbon-language/carbon-lang by zygoloid 4 years ago
- Fix pre-commit configuration See https://github.com/prettier/prettier/issues/9459 — committed to WeblateOrg/meta by nijel 4 years ago
- Migrate to new Prettier pre-commit repo pre-commit/pre-commit#1670 prettier/prettier#8925 prettier/prettier#9459 prettier/pre-commit#1 — committed to br3ndonland/inboard by br3ndonland 4 years ago
- Explain how to avoid the prettiermageddon when updating Recently prettier got broken badly (see https://github.com/prettier/prettier/issues/9459 and all the related PRs/issues there). This explains ... — committed to Tecnativa/doodba-copier-template by deleted user 4 years ago
- Explain how to avoid the prettiermageddon when updating Recently prettier got broken badly (see https://github.com/prettier/prettier/issues/9459 and all the related PRs/issues there). This explains ... — committed to Tecnativa/doodba-copier-template by deleted user 4 years ago
- specify node version that workarounds of https://github.com/prettier/prettier/issues/9459 — committed to key/django-project-template by key 4 years ago
- fix: Add default node version for pre-commit #73 If the cached pre-commit is deleted, pre-commit fails to install https://github.com/prettier/prettier/issues/9459 — committed to RGPosadas/Mull by bit172 4 years ago
- fix: Add default node version for pre-commit #73 If the cached pre-commit is deleted, pre-commit fails to install https://github.com/prettier/prettier/issues/9459 — committed to RGPosadas/Mull by bit172 4 years ago
The minimal fix: https://github.com/OCA/oca-addons-repo-template/pull/17/files
Could you please roll back whatever change broke all prettier pre-commit configurations and provide a smoother migration path please? All our tests went red everywhere, not nice… 😿 🙏
Can you try
Use the new one please.
But should that migration break preexisting configurations? We had our version pinned and it was broken too… Did you move the git tag or something like that? 🤔
This works, thank you very much !! The previous repo worked until today, didn’t know that there is an update.