generator-react-firebase: Fails to compile out of the box
Describe the bug
Generated and ran yarn start
and compile error occurs due to this issue: https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21.
I updated the extends
array in .eslintrc.js
replacing prettier
with plugin:prettier/recommended
to get past this error.
However, next I ran yarn start
again and am getting an error on ProjectsList.jsx
:
src/routes/Projects/components/ProjectsList/ProjectsList.jsx
Line 27:10: Replace `⏎····data:·projects⏎··}·=·useFirestoreCollectionData(⏎····projectsRef,⏎···` with `·data:·projects·}·=·useFirestoreCollectionData(projectsRef,` prettier/prettier
Line 32:1: Delete `··` prettier/prettier
Line 33:3: Replace `··}⏎··` with `}` prettier/prettier
To Reproduce Steps to reproduce the behavior:
- Installed this generator and ran
yo react-firebase
yarn start
Expected behavior/code I expected it to work out of the box
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 19 (19 by maintainers)
Commits related to this issue
- v7.6.3 * fix(build): use correct prettier config to prevent error - #369 — committed to prescottprue/generator-react-firebase by prescottprue 3 years ago
- v7.6.3 (#370) * fix(build): use correct prettier config to prevent error - #369 — committed to prescottprue/generator-react-firebase by prescottprue 3 years ago
- v7.6.5 (#381) fix: add back eslint-plugin-prettier (still needed for prettier) - #369 fix: cleanup lint in ProjectsList (was not getting picked up since prettier plugin wasn't loading) - #369 — committed to prescottprue/generator-react-firebase by prescottprue 3 years ago
Finally replicated! I was just checking the lint command, but start was picking up the issue you mentioned
@mikeover Great question - I’m actually looking at it right now and it should hopefully be pretty easy to get something out today (famous last words)
Personally use this to start projects, so want to keep it stable!
I opted out of redux.