prebid-server: tests fail for me on current head

Hi,

I’m trying to run validate.sh for the current github code and the tests are failing for me.

I’m on commit 54c996cc187565f4dcbf1e973b313d77b513543c

go is:

mstevens@DESKTOP-GT2RF3E:~/upstream/prebid-server$ go version
go version go1.18 linux/amd64

When I run validate I get test failures:

--- FAIL: TestStartWithPeriodicRun (0.03s)
    ticker_task_test.go:46:
                Error Trace:    ticker_task_test.go:46
                Error:          Not equal:
                                expected: 2
                                actual  : 3
                Test:           TestStartWithPeriodicRun
                Messages:       runner should have run three times
FAIL
FAIL    github.com/prebid/prebid-server/util/task       0.105s

and

2022/03/18 15:40:27 http: superfluous response.WriteHeader call from github.com/prebid/prebid-server/analytics/pubstack.TestFetchConfig.func1 (config_test.go:27)
2022/03/18 15:40:27 http: superfluous response.WriteHeader call from github.com/prebid/prebid-server/analytics/pubstack.TestFetchConfig_Error.func1 (config_test.go:52)
--- FAIL: TestPubstackModuleSuccess (0.24s)
    pubstack_module_test.go:179:
                Error Trace:    pubstack_module_test.go:179
                                                        pubstack_module_test.go:161
                Error:          Should receive an event, but did NOT
                Test:           TestPubstackModuleSuccess
                Messages:       AMP events are only published when logging an AMP object with AMP feature on
FAIL
FAIL    github.com/prebid/prebid-server/analytics/pubstack      0.276s

If I try to build the docker container I get a similar but slightly different failure:

2022/03/18 15:45:34 http: superfluous response.WriteHeader call from github.com/prebid/prebid-server/analytics/pubstack.TestFetchConfig.func1 (config_test.go:27)
2022/03/18 15:45:34 http: superfluous response.WriteHeader call from github.com/prebid/prebid-server/analytics/pubstack.TestFetchConfig_Error.func1 (config_test.go:52)
--- FAIL: TestPubstackModuleSuccess (0.24s)
    pubstack_module_test.go:179:
                Error Trace:    pubstack_module_test.go:179
                                                        pubstack_module_test.go:161
                Error:          Should receive an event, but did NOT
                Test:           TestPubstackModuleSuccess
                Messages:       auction events are only published when logging an auction object with auction feature on
FAIL
FAIL    github.com/prebid/prebid-server/analytics/pubstack      0.275s
--- FAIL: TestEventChannel_Push (0.04s)
    eventchannel_test.go:135:
                Error Trace:    eventchannel_test.go:135
                Error:          Not equal:
                                expected: "onethreefourfivesixseventwo"
                                actual  : "onetwothreefourfivesixseven"

                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -1 +1 @@
                                -onethreefourfivesixseventwo
                                +onetwothreefourfivesixseven
                Test:           TestEventChannel_Push
E0318 15:45:34.572730   11519 sender.go:31] [pubstack] Wrong code received 400 instead of 200
FAIL
FAIL    github.com/prebid/prebid-server/analytics/pubstack/eventchannel 0.117s

About this issue

Original URL
State: closed
Created 2 years ago
Comments: 15 (15 by maintainers)

Most upvoted comments

I’m happy to close. Thanks for your efforts.

On Tue, 5 Jul 2022 at 18:32, Scott Kay @.***> wrote:

I think we should be good here now. I rewrote the Pubstack tests to remove timing elements. The changes were tested and approved by Pubstack.

@michael-stevens https://github.com/michael-stevens Can we close this issue?

— Reply to this email directly, view it on GitHub https://github.com/prebid/prebid-server/issues/2190#issuecomment-1175320526, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEC2FIRWFEOHODO4NLJARHTVSRWR7ANCNFSM5RCGXKIQ . You are receiving this because you were mentioned.Message ID: @.***>

–

Michael Stevens Senior Developer ▪︎ Dianomi +44 207 802 5530 <+44%20207%20802%205530> @.*** 84 Eccleston Square London, SW1V 1PX www.dianomi.com

– This e-mail is for the sole use of the intended recipient and contains information that may be privileged and/or confidential. If you are not an intended recipient, please notify the sender by return e-mail and delete this e-mail and any attachments. Certain required legal entity disclosures can be accessed on our website.

michael-stevens on Jul 5, 2022

@SyntaxNode ok I’ve tested your branch, everything passed for validate.sh + go 1.18, for the docker build the pubstack test still failed (but you haven’t changed that yet obviously).

Thanks for your help.

michael-stevens on Mar 19, 2022