Prebid.js: Deal specific line items don't work

Type of issue

Deals don’t work as advertised in the docs.

Description

When creating a deal specific line item, that LI wins but the Universal Creative code doesn’t support it and only uses hb_adid which may not be the deal’s ad ID. My guess is that it’s not possible to know why GAM elected a LI to win with macros, so either the creative template or the UC code needs to be changed? Also, the deal’s ad ID, if it didn’t win, doesn’t seem to be sent in the key-values with enableSendAllBids: false.

Other information

This has already been reported (and ignored 😞) in #3266 back in november.

About this issue

Original URL
State: closed
Created 5 years ago
Comments: 24 (11 by maintainers)

Most upvoted comments

@benjaminclot - I’m not seeing a Prebid Universal Creative issue.

LI wins but the Universal Creative code doesn’t support it and only uses hb_adid which may not be the deal’s ad ID.

As noted in the comment way above, I updated the documentation to reflect how deals need to be set up. You’re right that won’t work without hb_adid_BIDDERCODE, but the alwaysIncludeDeals flag should fix that.

Note also that I submitted a docs PR to revise the enableSendAll bids section

https://github.com/prebid/prebid.github.io/pull/1507

bretg on Sep 23, 2019

Have a PR open and waiting for review.

https://github.com/prebid/Prebid.js/pull/4136

robertrmartinez on Aug 30, 2019

Update: this was pushed out of last sprint, but is in our current sprint

bretg on Aug 21, 2019

Thanks for the explanation – we’ll discuss what to do about this: understood that targeting values come in sets, and if we’re only providing one element of the set, that’s bad.

how is handled the case when a bidder has multiple bid responses, since there seems to be only one hb_KEY_BIDDER

Only the highest bid from each bidder is considered.

bretg on Jun 19, 2019