vscode-powershell: Formatting not working with 1.7.0

@SQLDBAWithABeard Just to document, importing the module from within VSCode won’t resolve the issue because PSScriptAnalyzer starts from a runspace pool when the extension starts up (which is precisely why using the -MinimumVersion flag is tricky).

PSScriptAnalyzer runs in its own sandbox essentially, so state changes in the editor won’t affect it. It works by sending the text of the script into the sandbox over to it and spitting results back out. This is good because it means it doesn’t depend on the state of the editor, so it can be parallelised.

Then when you start the extension up (formally, when you start the EditorServices process, which the extension does), it tacks its own modules directory onto the end of the module path. Which is nice because it means you can override its internal module versions by just sticking your own module anywhere on your module path. And the intent is that eventually it should be possible to integrate other modules with the extension just by having them on the path.

The problem was that despite going to the trouble of using the module path, we weren’t honouring it. Except now we have the issue that an incompatible version of PSScriptAnalyzer on the module path can break us, so we need to address that by somehow specifying what our version constraints are at load time…

@andikrueger it depends on whether you installed PSSciptAnalyzer with -Scope CurrentUser. For example, my PSModule path is:

/Users/tylerleonhardt/.local/share/powershell/Modules:/usr/local/share/powershell/Modules:/usr/local/microsoft/powershell/6.0.2/Modules

if I were to do

Install-Module PSScriptAnalyzer -Scope CurrentUser

The module would end up in the first location (aka the current user scope) in my PSModulePath:

/Users/tylerleonhardt/.local/share/powershell/Modules

if I were to do

Install-Module PSScriptAnalyzer

The module would end up in the second location in my PSModulePath:

/usr/local/share/powershell/Modules

It’s this again. I have 1.16.1 fodler in $HOME.vscode-insiders\extensions\ms-vscode.powershell-1.7.0\modules\PSScriptAnalyzer this time.

2018-04-28 07:41:40 [ERROR] - Method “InvokePowerShell” at line 445 of C:\projects\powershelleditorservices\src\PowerShellEditorServices\Analysis\AnalysisService.cs

The 'Invoke-Formatter' command was found in the module 'PSScriptAnalyzer', but the module could not be loaded. For more information, run 'Import-Module PSScriptAnalyzer'.

1524897678-76060de6-59b9-4e70-9686-24a835ab003d1524897335539.zip