swift-composable-architecture: Crash in Store.send(_:originatingFrom:)

Description

We are seeing a crash in Store.send(_:originatingFrom:), as shown by this Crashlytics call stack:

It’s difficult to see how this could happen, given that self.bufferedActions is protected by an !self.bufferedActions.isEmpty check here:

      if !self.bufferedActions.isEmpty {
        if let task = self.send(
          self.bufferedActions.removeLast(), originatingFrom: originatingAction
        ) {
          tasks.wrappedValue.append(task)
        }
      }

We are using swift-composable-architecture v0.45.0, although it appears the code from v0.45.0 is the same as the code in the main branch.

Checklist

• I have determined whether this bug is also reproducible in a vanilla SwiftUI project.
• If possible, I’ve reproduced the issue using the main branch of this package.
• This issue hasn’t been addressed in an existing GitHub issue or discussion.

Expected behavior

No crash.

Actual behavior

See the Crashlytics call stacks above.

Steps to reproduce

It is intermittent, and does not happen very often.

The Composable Architecture version information

0.45.0

Destination operating system

No response

Xcode version information

Xcode 14.1

Swift Compiler version information

ehyche in ~/src/github/noom/coach-ios (ehyche/ARM-778-cached-or-fresh) > xcrun swiftc --version
swift-driver version: 1.62.15 Apple Swift version 5.7.1 (swiftlang-5.7.1.135.3 clang-1400.0.29.51)
Target: arm64-apple-macosx12.0