godot-admob-android: [BUG] Error compiling Godot for iOS with module for version 3.2.4 beta 5
Describe the bug I’m trying to compile godot using Godot-AdMob-Android-iOS as a module, but I’m getting forward declaration errors in the iOS source:
To Reproduce Steps to reproduce the behavior:
- Place
ios/admobcontents intogodot/modules/admob - Place google
*.frameworkdirectories intogodot/modules/admob/lib - Run
scons p=iphone target=debug
Expected behavior
Builds an ios *.a file
Screenshots If applicable, add screenshots to help explain your problem.
Smartphone (please complete the following information):
- Latest Godot-AdMob-Android-iOS as of this writing
- Latest godot from git
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 39 (23 by maintainers)
Commits related to this issue
- #41 Update — committed to poingstudios/godot-admob-android by gumaciel 3 years ago
- #41 change "reference.h" to "object.h" — committed to poingstudios/godot-admob-android by gumaciel 3 years ago
- #41 Change "admob_api" due Godot and GDScript singleton — committed to poingstudios/godot-admob-android by gumaciel 3 years ago
- #41 Re-do iOS module to work on 3.2.4 version — committed to poingstudios/godot-admob-android by gumaciel 3 years ago
- #41 Update — committed to poingstudios/godot-admob-android by gumaciel 3 years ago
- #41 change "reference.h" to "object.h" — committed to poingstudios/godot-admob-android by gumaciel 3 years ago
- #41 Re-do iOS module to work on 3.2.4 version — committed to poingstudios/godot-admob-android by gumaciel 3 years ago
- #41 Update Former-commit-id: fc0548ae237648dca82525d407cd95e03d6ced24 — committed to poingstudios/godot-admob-android by gumaciel 3 years ago
- #41 change "reference.h" to "object.h" Former-commit-id: b8851ceafc82e145ac81dba01a582c8b05cc1892 — committed to poingstudios/godot-admob-android by gumaciel 3 years ago
- #41 Re-do iOS module to work on 3.2.4 version Former-commit-id: 5500f5a897d70823ca4a6d88cd136af834686558 — committed to poingstudios/godot-admob-android by gumaciel 3 years ago
- #41 Update Former-commit-id: 9665cf6e81c242f45e1b28409279de9519cb0257 [formerly fc0548ae237648dca82525d407cd95e03d6ced24] Former-commit-id: 8d1bbddec253ce12adb33a2a63d18b1098e37889 — committed to poingstudios/godot-admob-android by gumaciel 3 years ago
- #41 change "reference.h" to "object.h" Former-commit-id: fe0610b28c5035c84716b736cdcc6d17ae78c610 [formerly b8851ceafc82e145ac81dba01a582c8b05cc1892] Former-commit-id: 82ad3830afdb86c7fea64c66c8e762... — committed to poingstudios/godot-admob-android by gumaciel 3 years ago
- #41 Re-do iOS module to work on 3.2.4 version Former-commit-id: 5847c4b529c8480510c35a67afd44d2cad75abbd [formerly 5500f5a897d70823ca4a6d88cd136af834686558] Former-commit-id: aa0c96bcaa9ff4a008e79bc... — committed to poingstudios/godot-admob-android by gumaciel 3 years ago
@gustavottc Busy day! Just wanted to chime in here that I’ve pulled your latest changes as of 20 minutes ago, compiling against the 3.2 HEAD on godot and it looks like everything is working just as it was when I was using the precompiled versions earlier this week. Thanks to you as well @naithar!
https://github.com/godotengine/godot/blob/8b6357cf28944301dc816b2bd07900c16396f7a7/platform/iphone/os_iphone.mm#L710-L44
This two functions should probably cover your case, but it requires testing anyway.
Yeah, I’ve finally managed to setup project and everything is working fine after singleton name change, but I guess basic stuff for upgrading is done. Your should probably fix other warning just to make compiler happy.
I’ve also encountered your previous issue: https://github.com/godotengine/godot/issues/44681. I’m still not sure how to reproduce it 100%, but I’ll take a closer look when I can.
Since your GDScript singleton and AdMob module singleton have the same name, Godot is probably mistaking one for another when module is actually compiled.