PnP-Tools: Oslo Design Error
Hi,
everytime I’m loading an oslo page with the responsive design enabled I’m getting this error:
TypeError: Cannot read property 'cloneNode' of null at Object.setUpToggling (SP-Responsive-UI.js:195) at Object.init (SP-Responsive-UI.js:118) at responsiveStartup (SP-Responsive-UI.js:299) at eval (eval at ProcessOnLoadFunctionNames (init.js?rev=XhcVShqV%2FkUCdcpWykXmOA%3D%3DTAG0:1), <anonymous>:1:43) at ProcessOnLoadFunctionNames (init.js?rev=XhcVShqV%2FkUCdcpWykXmOA%3D%3DTAG0:1) at ProcessDefaultOnLoad (init.js?rev=XhcVShqV%2FkUCdcpWykXmOA%3D%3DTAG0:1) at NotifyEventAndExecuteWaitingJobs (init.js?rev=XhcVShqV%2FkUCdcpWykXmOA%3D%3DTAG0:1) at NotifyScriptLoadedAndExecuteWaitingJobs (init.js?rev=XhcVShqV%2FkUCdcpWykXmOA%3D%3DTAG0:1) at $_global_core (core.js?rev=cirE17cPtkMjQL7%2F4SQ%2BAg%3D%3DTAG0:1) at core.js?rev=cirE17cPtkMjQL7%2F4SQ%2BAg%3D%3DTAG0:1
On Internet Explorer this error message even gets into a loop until the whole site crashes.
I guess cloneNode is only present in the seattle design and that’s why it gets null for oslo. Maybe some try catch or if would help?
Is there a way to disable the responsive design for oslo and keep it only enabled for seattle?
Thanks, Igor
About this issue
- Original URL
- State: closed
- Created 7 years ago
- Comments: 25 (13 by maintainers)
Hi @igorb90, in fact, currently the Oslo Master Page is not supported by the ResponsiveUI. I’m working on it and maybe other people too… A solution should be coming soon.
Hi @Laul0 , great news! I’m using it in production now and it works very good 😃 Thanks a lot for your awesome work!
Hi @igorb90 ! The new version was merged! 💪🏻 If this version fix your issue could you close it ? If you find other issues, don’t hesitate 😉
Hi @celings, you’re right! Currently I’m developing on my own repository before the first WIP PR. I have to finalise some little things and I should can do the PR at the end of the week. At worst, at the beginning of the next week. I’m not only working on the Oslo compatibility. I’m working on little bit more use cases 😉
Hi @igorb90, I think I know what you mean about a scroll that appear some time at the half page.
That will be fixed (normally) in my next commit 😉
Hi @Laul0 , I don’t know how but I actually downloaded the wrong files from github. Sorry, my fault. I think I got the right one now:
The sidebar looks sick, love it! Everything looks great and is working properly so far. I’ll deploy it to a production Site Collection for further testing.
Hi @igorb90, in accordance with your screenshot, its look like the new version of cascading stylesheet and/or maybe the JavaScript file are not effective…
Normally, you don’t should have this result. Could you refer to the bellow link to show the expected result ? https://github.com/Laul0/PnP-Tools/blob/731b4e17b73bd245a1e96df2f11e63806b961f84/Solutions/SharePoint.UI.Responsive/README.md
Great! I’ll start working with it tomorrow and report back any bugs when I encounter them. For now, props + thanks! 😃
2018-06-25 11:11 GMT+02:00 Laul0 notifications@github.com:
That’s great news - @Laul0 has really done a great job on the seattle.master support already and we absolutely appreciate the work here. Can’t stress enough how valuable this work is for the rest of the community as there is still plenty of customers who are using classic experiences even in online.
Hi Chris,
I’m currently working on it because I also need it for one of my customers… I have to find a generic solution that can be answered to a maximum of use cases.
That should not be too long 😉 (I hope)