cli-microsoft365: Upgrade spfx 1.6 FN002008 saves exact when it shouldn't

When upgrading a project from spfx 1.5.1 to 1.6.0 the report instructs the following command:

npm i tslint-microsoft-contrib@5.0.0 --save-exact -D

However the default version specification for this package when scaffolding a net new project is ~5.0.0. I don’t think this is a big problem, however if tomorrow 1.6.1 comes along and the cli implements the upgrade sequence as well, a project that was upgraded from 1.5.1 will trigger a finding for this rule.

About this issue

  • Original URL
  • State: closed
  • Created 6 years ago
  • Comments: 23 (23 by maintainers)

Most upvoted comments

thanks for taking the time to discuss this item. closing for now

side note, if this needs fixing, that probably means that #572 needs the “inexact” arrays again. Let me know how this goes, I’ll update my PR accordingly.