cli-microsoft365: spfx project upgrade seems to break gulp bundle --ship
Description
Firstly, not sure if this a bug or indeed can be fixed easily with any file modifications.
Gone through the steps as listed in upgrade report and referenced in Issue#1574 . See also my comments on the incorrect spfx version: Enhancement: Extend SPFx project version detection with checking if .yo-rc.json and package.json are in sync issue #1488 .
Steps to reproduce
Went through the steps as listed in the upgrade report.
npm install
Expected result
The spfx project should be gulp bundle happy!
Actual result
Note: there might be some more steps as hinted at in the recommendations but this is a bit unclear IMHO 😐.
Environment
npm install -g @pnp/office365-cli@next 2.10.0-beta.4206056
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Comments: 15 (8 by maintainers)
Ah Yes, @hugoabernier did give me a quick demo of that. Yes, being guided whilst making the changes will be great.
Thanks for replying. The irony, is I wanted to quickly upgrade this project; so I could help out on those “good first issues”, but I kept running into issues 😏. Note to self: run away from elderly SPFx 1.2 project upgrades!
Anyway, Node version
* 10.15.3 (Currently using 64-bit executable)Late last night, I created a local standalone repo of the upgraded project . With some assistance, from @hugoabernier the project upgrade is now fixed.
I can also test out your suggestions on a copy of the standalone repo to see how this compares with the work undertaken last night.
@waldekmastykarz if the issue has been fixed, and tested on other samples then yes pls close. I am happy to try the project upgrade again, if needed.
Thanks for bringing this to our attention @westerdaled!
npm dedupeafter upgrading all packages? If not, could you please see if it helps?npm dedupedoesn’t help, could you try deleting the lockfile and runningnpm installagain to see if that helps?Sorry for the trouble.