cli-microsoft365: Not able to run npm run test on fresh Windows install

Hi, I have the issue with node v12.13.0 but also had the issue with node 10 on the same machine.

br, Patrick

@waldekmastykarz: works meanwhile.Closing the issue

As we have just released v2.5 of the CLI this should no longer be an issue, as we have replaced istanbuljs (nyc) with c8 as our test coverage tool in this release.

@eiriksanderfjeld @plamber can you confirm that the issue no longer remains when using the latest version of the CLI on a clean Windows install?

Please note that you will now require node v12 from v2.5 onwards, we will be updating our documentation to reflect this dependency under issue #1312.

Hi, i cloned the repo on a fresh windows 10 install (1909) and installed node 12.13.1. I got the same error as @plamber. I removed nyc, and installed 15.0.0-beta.0, which solved the original problem. However three tests (spfx project externalize, spfx project externalize, spfx project externalize) fails.

I will try to do the test fix next week and let you know if all is good.

According to this istanbuljs/nyc#1205 v14 will not solve the issue, it is 15.0.0-beta.1 and then v15 when it is out. I tested it with 15.0.0-beta.1 it was working ok.

@waldekmastykarz, it fails because of nyc module in the dev dependencies.

The test is a side effect after the upgrade.

@plamber , @garrytrinder , @waldekmastykarz I was able to repro with

λ node -v
v12.13.1
λ npm -v
6.12.1
Windows 10 Pro 1809

Possible solutions:

• Upgrading the nyc to 15.0.0-beta.0 solved the issue as mentionaed here: https://github.com/istanbuljs/nyc/issues/1205
• Upgrading the nyc to 15.0.0-beta.1 solved the issue as well
• Downgrading nyc did not worked for me.
• Upgrading to nyc to 15.0.0 should work best, but we have to wait until released.

The unit test fails because, I ASSUME there has been update in Node 12 require to output more information, therefore the assertion fails since the expectation for a shorter message. However, if there is a missing module that message is actually longer than the assertion so perhaps we should align the unit test.

This is the actual error coming from require.

Error: Cannot find module './project-upgrade/upgrade-0'
Require stack:
- C:\cmder\office365-cli\dist\o365\spfx\commands\project\project-upgrade.js
- C:\cmder\office365-cli\dist\o365\spfx\commands\project\project-upgrade.spec.js
- C:\cmder\office365-cli\node_modules\mocha\lib\mocha.js
- C:\cmder\office365-cli\node_modules\mocha\lib\cli\one-and-dones.js
- C:\cmder\office365-cli\node_modules\mocha\lib\cli\options.js
- C:\cmder\office365-cli\node_modules\mocha\bin\mocha
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:797:15)
    at Function.Module._load (internal/modules/cjs/loader.js:690:27)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at Module.patchedRequire [as require] (C:\cmder\office365-cli\node_modules\diagnostic-channel\dist\src\patchRequire.js:14:46)
    at require (internal/modules/cjs/helpers.js:74:18)
    at C:\cmder\office365-cli\dist\o365\spfx\commands\project\project-upgrade.js:3:261
    at Array.forEach (<anonymous>)
    at SpfxProjectUpgradeCommand.commandAction (C:\cmder\office365-cli\dist\o365\spfx\commands\project\project-upgrade.js:3:180)
    at Object.action (C:\cmder\office365-cli\dist\o365\spfx\commands\project\project-upgrade.js:1:85015)
    at Context.<anonymous> (C:\cmder\office365-cli\dist\o365\spfx\commands\project\project-upgrade.spec.js:459:21)
    at callFn (C:\cmder\office365-cli\node_modules\mocha\lib\runnable.js:387:21)
    at Test.Runnable.run (C:\cmder\office365-cli\node_modules\mocha\lib\runnable.js:379:7)
    at Runner.runTest (C:\cmder\office365-cli\node_modules\mocha\lib\runner.js:535:10)
    at C:\cmder\office365-cli\node_modules\mocha\lib\runner.js:653:12
    at next (C:\cmder\office365-cli\node_modules\mocha\lib\runner.js:447:14)
    at C:\cmder\office365-cli\node_modules\mocha\lib\runner.js:457:7
    at next (C:\cmder\office365-cli\node_modules\mocha\lib\runner.js:362:14)
    at C:\cmder\office365-cli\node_modules\mocha\lib\runner.js:420:7
    at done (C:\cmder\office365-cli\node_modules\mocha\lib\runnable.js:334:5)
    at callFn (C:\cmder\office365-cli\node_modules\mocha\lib\runnable.js:410:7)
    at Hook.Runnable.run (C:\cmder\office365-cli\node_modules\mocha\lib\runnable.js:379:7)
    at next (C:\cmder\office365-cli\node_modules\mocha\lib\runner.js:384:10)
    at Immediate._onImmediate (C:\cmder\office365-cli\node_modules\mocha\lib\runner.js:425:5)
    at processImmediate (internal/timers.js:439:21) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    'C:\\cmder\\office365-cli\\dist\\o365\\spfx\\commands\\project\\project-upgrade.js',
    'C:\\cmder\\office365-cli\\dist\\o365\\spfx\\commands\\project\\project-upgrade.spec.js',
    'C:\\cmder\\office365-cli\\node_modules\\mocha\\lib\\mocha.js',
    'C:\\cmder\\office365-cli\\node_modules\\mocha\\lib\\cli\\one-and-dones.js',
    'C:\\cmder\\office365-cli\\node_modules\\mocha\\lib\\cli\\options.js',
    'C:\\cmder\\office365-cli\\node_modules\\mocha\\bin\\mocha'
  ]
}
CommandError {
  message: "Cannot find module './project-upgrade/upgrade-0'\n" +
    'Require stack:\n' +
    '- C:\\cmder\\office365-cli\\dist\\o365\\spfx\\commands\\project\\project-upgrade.js\n' +
    '- C:\\cmder\\office365-cli\\dist\\o365\\spfx\\commands\\project\\project-upgrade.spec.js\n' +
    '- C:\\cmder\\office365-cli\\node_modules\\mocha\\lib\\mocha.js\n' +
    '- C:\\cmder\\office365-cli\\node_modules\\mocha\\lib\\cli\\one-and-dones.js\n' +
    '- C:\\cmder\\office365-cli\\node_modules\\mocha\\lib\\cli\\options.js\n' +
    '- C:\\cmder\\office365-cli\\node_modules\\mocha\\bin\\mocha',
  code: undefined
}
    1) shows error when a upgrade rule failed

We have just Error: Cannot find module './project-upgrade/upgrade-0 in the assertion.

Found another closed issue which is a potential fix

https://github.com/istanbuljs/nyc/issues/1163

Looks like the issue lies with npm 6.11 and not node, I’ll take a look at testing the fix later this afternoon.

Got it. Shall we then rename this issue to make it clear that it’s specific to Node v12 and then we can use it to track the work towards supporting it?

Regarding Istanbul, I’ve been delaying its upgrade, because each time I did it, the coverage report got empty. After trying out some fixes, I got it to show something, but not the 100% we have, which is odd, given it’s the same code.

With that said, Node v12 is LTS so we should definitely start looking into ways of supporting it. Also, the version of Istanbul that we’re using is quite old so it would be good to upgrade to the latest too.

Will try repro to tomorrow.

Hi, I am getting the project test failure also on my MAC. I ignored it so far because I was still able to commit my changes without affecting the coverage.

Hope this helps

I will try on fresh VM and let you know.