semantic-release-monorepo: @semantic-release/github adds comments to the wrong issues
It looks like @semantic-release/github adds comments to the wrong issues when used in monorepo
About this issue
- Original URL
- State: closed
- Created 6 years ago
- Comments: 17 (6 by maintainers)
Commits related to this issue
- chore(semantic-release): disable success plugins [skip ci] Github/success leaves comments for wrong issues due to https://github.com/Updater/semantic-release-monorepo/issues/51 and https://github.com... — committed to stalniy/casl by stalniy 6 years ago
- chore: disable commenting on issues and pull requests on release Because of the monorepo structure, `semantic-release-monorepo` cannot determine which pull-requests and issues are supposed to be comm... — committed to GabeDuarteM/gd-scripts by GabeDuarteM 4 years ago
- fix: wrap success and fail plugins This should allow the posting of comments to work when using the `github` plugin. [Fixes #51] — committed to pmowrer/semantic-release-monorepo by pmowrer 4 years ago
- fix: wrap success and fail plugins This should allow the posting of comments to work when using the `github` plugin. [Fixes pmowrer/semantic-release-monorepo#51] — committed to cypress-io/cypress by pmowrer 4 years ago
Thanks so much for trying it out @travi! That’s good enough for me… just published a new release with the fix!
Our releases are taking longer and longer because it’s adding so many comments to PRs. If someone can point me to the location of what to fix, I can take a stab at it. Maybe wrapping the success plugin?
Haven’t had a chance to look at this… Thanks for the research!
Sounds like maybe all we need to do is wrap the
successplugin like we do the others. The primary reason this library even exists is to allow monkey patching the output ofgetCommitsto filter commits based on package sincesemantic-releasewon’t allow it.