jotai: atoms and error boundaries

I’m trying out jotai in one of my projects and it was crashing with code like this

 React.useEffect(() => {
    setState(s => {
      const x = {};
      delete x[123][123];
    });
  });

and I was confused why this error wasn’t caught by the react error boundary (of react-error-boundary fame). Then I realized that my component three was like this JotaiProvider -> ErrorBoundary -> MyComponent so doing something like ErrorBoundary -> JotaiProvider -> ErrorBoundary -> MyComponent helped, but it makes me realize interesting consideration that with smaller context providers I can have them closer to my component and thus making errors more local, but errors in jotai are basically globally scoped 😃

I don’t know if that’s an issue per se, but maybe a good point to consider when deciding between custom context vs global context

About this issue

Original URL
State: closed
Created 4 years ago
Comments: 17 (17 by maintainers)

Most upvoted comments

can confirm that v0.10.0 fixes both example on codesandbox and the issue in my app

JLarky on Oct 19, 2020

So, with both set*, it shows High level oopsie..., and if we comment out the first one, it shows Oopsie on Crash level.... Good point.

This is because of the place we invoke atom.write function. But, I agree it’s weird. I guess this reveals another issue about batched writes.

We throw errors in render (atom.read) to error boundaries, but for atom.write we throw errors to the write function (even if it’s async write).

I also find my explanation wasn’t so accurate, because it shows error boundaries. I may have misunderstood something.

Let me think if I can write a test case for this.

dai-shi on Oct 17, 2020

I tried to reproduce it again, and as far as it looks both 0.7 and 0.9 work without issues. So I’m closing this because that thing with hot reload is not a huge deal, and I don’t see those issues that I first saw.

JLarky on Oct 16, 2020

OK, I’d say the hot reload behavior is a limitation of current implementation (or theoretical one). Check out this example: https://codesandbox.io/s/jotai-issue-92-forked-om7e9?file=/src/atoms.ts

yes, this one works as expected. Did you just move atom into different file and that’s it? 😃

Anyway 😃 I will try to reproduce the exact issue I was having on my end if we can’t do anything with this hot reload example 😃

JLarky on Oct 11, 2020