pixijs: Blocking local test failure after merging non-RGBA8 multisampled framebuffers

Since merging #7619 I’m consistently getting this error. It’s blocking me from making a new v7 release. This isn’t failing on CI.

Summary of all failing tests
 FAIL  packages/core/test/RenderTexture.tests.ts
  ● Test suite failed to run

      ● RenderTexture › FloatRenderTexture › should render correctly with mask, multisampling, and format RED / type FLOAT

        expect(received).toEqual(expected) // deep equality

        Expected: 1
        Received: 0.30000001192092896

          387 |             gl.readPixels(0, 0, 1, 1, gl.RED, gl.FLOAT, pixel);
          388 |
        > 389 |             expect(pixel[0]).toEqual(1.0);
              |                              ^
          390 |
          391 |             pixel.set([0.1]);
          392 |

      at Object.<anonymous> (packages/core/test/RenderTexture.tests.ts:389:30)
        ● RenderTexture › FloatRenderTexture › should resize multisampled framebuffer with format RED / type FLOAT
          expect(received).toEqual(expected) // deep equality
          Expected: 1
          Received: 0.30000001192092896
            430 |             gl.readPixels(1, 1, 1, 1, gl.RED, gl.FLOAT, pixel);
            431 |
          > 432 |             expect(pixel[0]).toEqual(1.0);
                |                              ^
            433 |         });
            434 |     });
            435 | });
      at Object.<anonymous> (packages/core/test/RenderTexture.tests.ts:432:30)

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Reactions: 1
  • Comments: 16 (16 by maintainers)

Most upvoted comments

Seems that there is some problem renderer.framebuffer.blit(). Let me see if I can fix this…

Changing MSAA_QUALITY didn’t seem to work 🤔