tidb: TiDB v2.1.2 build failed for wrong tidb-tools version
Bug Report
- What did you do?
I’m the maintainer of tidb on AUR, and also the maintainer from archlinuxcn which provides tidb binary.
I tried to bump tidb version to 2.1.2 but failed error.
- What did you expect to see?
I expect to see tidb built with success.
- What did you see instead?
tidb build failed with error:
# command-line-arguments
tidb-server/main.go:193:17: undefined: client.NewLocalPumpsClient
- What version of TiDB are you using (
tidb-server -V
or runselect tidb_version();
on TiDB)?
v2.1.2
Some more info:
NewLocalPumpsClient
was introduced in PR https://github.com/pingcap/tidb/pull/8747, but in this pr, go.mod
has been set to 2.1.1 instead of 2.1.2: https://github.com/pingcap/tidb/pull/8747/files#diff-37aff102a57d3d7b797f152915a6dc16L53
And NewLocalPumpsClient
was introduced in commit which tagged to 2.1.2
About this issue
- Original URL
- State: closed
- Created 6 years ago
- Comments: 16 (15 by maintainers)
No,
v2.1.7
is usinggo 1.11.3
@Xuanwo https://github.com/pingcap/tidb/blob/v2.1.7/circle.yml#L6Try Go1.11.3