Bug report

Phpstan version 1.6.3

Hello, i have updated today phpstan to last version, wanting to try the bleeding edge features, I activated them and it seems that it is a problem to recognize that a class of LexikJWTAuthenticationBundle extends from JsonResonse and therefore from Response.

This class have a comptibility layer, can this be the problem? https://github.com/lexik/LexikJWTAuthenticationBundle/blob/2.x/Response/JWTAuthenticationFailureResponse.php

Code snippet that reproduces the problem

I don’t think i can reproduce it on https://phpstan.org/try, but i think it can be easy to reproduce it in a symfony controller:

<?php

declare(strict_types=1);

namespace App\Controller;

use Lexik\Bundle\JWTAuthenticationBundle\Response\JWTAuthenticationFailureResponse;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\Routing\Annotation\Route;

class TestController extends AbstractController
{
    #[Route(data: '/test'), method: 'POST']
    public function index(): JsonResponse
    {
        return new JWTAuthenticationFailureResponse();
    }
}

<?php

declare(strict_types=1);

namespace App\Tests\Functional\Controller;

use Lexik\Bundle\JWTAuthenticationBundle\Response\JWTAuthenticationFailureResponse;
use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
use Symfony\Component\HttpFoundation\Request;

class TestControllerTest extends WebTestCase
{
    // The test works, and when i dd($client->getResponse() instanceof JsonResponse) the result is true
    public function testIndex(): void
    {
        $client = static::createClient();
        $client->request(method: Request::METHOD_POST, uri: '/test');

        self::assertInstanceOf(JWTAuthenticationFailureResponse::class, $client->getResponse());
    }
}

Expected output

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Controller/TestController.php                                                                                                                                                                      
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  17     Method App\Controller\TestController::index() should return Symfony\Component\HttpFoundation\JsonResponse but returns Lexik\Bundle\JWTAuthenticationBundle\Response\JWTAuthenticationFailureResponse.  
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/Functional/Controller/TestControllerTest.php                                                                                                                                                                                         
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  18     Call to static method PHPUnit\Framework\Assert::assertInstanceOf() with 'Lexik\\Bundle\\JWTAuthenticationBundle\\Response\\JWTAuthenticationFailureResponse' and Symfony\Component\HttpFoundation\Response will always evaluate to false.  
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

Did PHPStan help you today? Did it make you happy in any way?

Yes, it certainly changed my way of coding for the better, thanks for your work 😄