phpactor: Crash when trying to go to definition: undefined variable: g:phpactorProjectRootPatterns

phpactor crashes when I try to use GotoDefinition on the DoctrineCommand class here: https://github.com/doctrine/DoctrineFixturesBundle/blob/master/Command/LoadDataFixturesDoctrineCommand.php#L30

Error detected while processing function phpactor#GotoDefinition[1]..phpactor#_GotoDefinitionTarget[1]..phpactor#rpc:
line    6:
E121: Undefined variable: g:phpactorProjectRootPatterns
E116: Invalid arguments for function s:searchDirectoryUpwardForRootPatterns( fnamemodify(phpactor#_path(), ':h'), g:phpactorProjectRootPatterns, g:phpactorInitialCwd)
line   12:
E121: Undefined variable: g:phpactorPhpBin
line   14:
E121: Undefined variable: l:cmd
E116: Invalid arguments for function system(l:cmd, json_encode(request))
Error detected while processing function phpactor#GotoDefinition[1]..phpactor#_GotoDefinitionTarget[1]..phpactor#rpc:
line   20:
E605: Exception not caught: Could not parse response from Phpactor: Vim(let):E121: Undefined variable: result

About this issue

Original URL
State: closed
Created 4 years ago
Comments: 23 (16 by maintainers)

Most upvoted comments

@dantleech I guess moving variables to a plugin/phpactor.vim file would do the trick. Even if those things are loaded its’ not much, 10 lines maybe.

kristijanhusak on Apr 11, 2020

As a temporary fix, remove this line from your vimrc and move phpactor from the opt directory into the start directory.

That works indeed, thanks! cc @kristijanhusak, this might be of some interest to you since phpactor is used as a good example of an optional package in the README of vim-packager.

greg0ire on Apr 11, 2020

No, the functions would still be available and we should keep it that way since they just got deprecated. I don’t how many version you want to wait until introducing a BC break.

From :h <Plug>:

The special key name “<Plug>” can be used for an internal mapping, which is not to be matched with any key sequence.

A little bit clearer with :h using-<Plug>:

<Plug> is a special code that a typed key will never produce.

So the idea is that you create a mapping that will never conflict with any one, as long as the name is unique enough of course. Doing so the user just have to do:

nmap <buffer> <silent> <C-]> <Plug>(PhpactorGotoDefinition)

We will have to check the recommendations for the parenthesis because you see plugins with and without them.

camilledejoye on Apr 12, 2020

I think there is another factor here:

I’m using :call phpactor#GotoDefinition

So that is now “deprecated” and everybody should ideally use the command equivalent, :PhpactorGotoDefinition - which is only defined with the FT Plugin.

The documentation now reflects this, but I guess lots of people are still using the functions directly…

dantleech on Apr 12, 2020

OK, I think I managed to reproduce it with only phpactor as plugin on Vim

camilledejoye on Apr 11, 2020

Could also be something to do with Plug - as I think @greg0ire is using the native VIM package manager, and in the other issue the user was using Dein.

dantleech on Apr 11, 2020

Hi, on master or develop ? You got the error every time ? Others RPC call works as expected ? Have you try to turn vim off and on again ? 😃 (but seriously in case a previous action would have unset a variable or something)

camilledejoye on Apr 11, 2020