PHP-CS-Fixer: Incorrect continuation indentation with 3.9.x
Bug report
The wrong continuation indentation is being applied since 3.9.x. Instead of the expected 4, it is now 2.
Also tested with latest master, no changes unfortunately.
Code snippet that reproduces the problem
All details can be found on the renovate/friendsofphp-php-cs-fixer-3.x branch on https://github.com/Drenso/symfony-oidc/tree/renovate/friendsofphp-php-cs-fixer-3.x. See https://github.com/Drenso/symfony-oidc/commit/443de599380a20a122cb22e69e08a0309b06210f for the changeset generated with our CI.
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 17 (17 by maintainers)
While I appreciate the effort you put into this feature, I decided to reject this feature to be merged into the mainline of this project, for now.
For now, you may disable the rule you don’t like in your config, register your fixer as a custom one locally, or adjust your style to follow the widely used standard.
I will re-consider this decision if this feature will get more support from a wide user audience or become part of PHP fig guideline.
I’m sorry, I realize I confused this with another feature from PhpStorm I do use: soft-wraps additional indent, which is not written in the file on save. I actually agree with @keradus and @SpacePossum: having extra indentation for statement continuation seems to be an edge case and I don’t think it’s worth making
statement_indentationeven more complex.Sorry about that. Sadly we don’t have much free time to handle all the contributions but you’re very welcome to implement this.