vimium: Bookmarklet doesn't run when executed through vomnibar
If I hit b and in the vomnibar try to run my “+ Pocket” bookmarklet (by hitting ENTER) nothing happends. If I click the bookmark manually in the bookmarks bar everything works fine. Worked fine a couple of days ago.
About this issue
- Original URL
- State: closed
- Created 9 years ago
- Comments: 51 (13 by maintainers)
Commits related to this issue
- Re-fix javascript: bookmarks. It seems javascript: bookmarks aren't fixed after all. Fixes #1611. — committed to smblott-github/vimium by smblott-github 9 years ago
- Fix javascript: URIs. This is @mrmr9393's suggestion from #1636. It mimic's Chrome's behaviour when a javascript: URI is enetered into the omnibox (or clicked). Fixes #1611. — committed to smblott-github/vimium by smblott-github 9 years ago
- Don't decode javascript URIs on 46.0.2467.2 and later The fix for Chromium issue 483000 landed in this version, so it is no longer necessary for #1611 — committed to mrmr1993/vimium by mrmr1993 9 years ago
- Don't decode javascript URIs on 46.0.2467.2 and later The fix for Chromium issue 483000 landed in this version, so it is no longer necessary for #1611 — committed to mrmr1993/vimium by mrmr1993 9 years ago
OK. Thanks @marlun. So the bookmarklet is running, and appears to be running in the correct context. Which is a good start.
Here are three versions of the Pocket bookmarklet:
The first two are abbreviated, the third is the full thing. The first two don’t do anything, but they shouldn’t produce any error messages on the console. Would you be able to check which is the first one to produce an error message?
Another thing to try is simply taking the full text of the Pocket bookmarklet (the third line above) and running it in the console (
Ctrl-Shift-I).I am also running into the same problem with the Twitter bookmarklet. For some reason, it is stored with URL escapes, unlike other bookmarklets.
Hmm. I just got a different error…
Yes, I’m getting an error: