learnGitBranching: Unable to get past "hide goal" phase at the very first tutorial

Hello,

I was unable to do anything after the “Goal To Reach” window pops up. When I click any of the window buttons of the goal window, nothing happened. Then I tried to write down hide goal on the console; no luck either.

This error comes up on the browser console: this.goalVis is undefined

I tried this on an Ubuntu Linux, Firefox, Brave and Chrome’s latest browsers. I saw the issue on every one of them

Thanks!

About this issue

Original URL
State: closed
Created 4 years ago
Reactions: 17
Comments: 22 (4 by maintainers)

Commits related to this issue

Add `draggable` of `jquery-ui` Fixed #687, #688 — committed to hong4rc/learnGitBranching by hong4rc 4 years ago
Update master (#1) * Change esversion to 6 * Fix resize width and height to -1 * Resolves #574 -- move npm to yarn everywhere else * Update yarn.lock file A number of recent commits have ... — committed to dmwelch/learnGitBranching by dmwelch 4 years ago

Most upvoted comments

This should be an important issue to fix. I was very interested in trying out this tool to enhance knowledge of git and was immediately stopped because of this issue. It will deter people from using this product. Please fix soon this seems like a great tool!

bryangators on Apr 24, 2020

I think adding either:
<script defer src="lib/jquery-ui-1.9.0.custom.min.js"></script>
to line 361 of src\template.index.html

or changing line 95 of gulpfile.js to: entries: […glob.sync(‘src//*.js’), …glob.sync('src//*.jsx’),‘lib/jquery-ui-1.9.0.custom.min.js’],

should fix this

We use jquery 3.5, jquery-ui 1.9 cannot compatible with it, I create a PR to fix this issue.

Quick demo: https://hong4rc.github.io/test/index.html

hong4rc on Apr 24, 2020

When you drag the goal window, the goal window will be closed directly instead of moving.

Thank you, fixed it. Please report any bug if you see it.

hong4rc on Apr 24, 2020