ServiceBusExplorer: Incorrect version showed
Steps to repro
- Have an older version running locally (4.0.105).
- Esure to be be connected to the internet
- Version showed will be not the actual version, but the latest available on GitHub (latest release)
I suspect either embedded version is not embedded properly or VersionHelper has a bug.
Originally, there was a VersionProvider to determine product version, but it’s no longer used.
MainForm only invokes VersionHelper, which seems to be the issue.
About this issue
- Original URL
- State: closed
- Created 6 years ago
- Comments: 47 (16 by maintainers)
👍 to what @danielmarbach said. There’s an issue for that, #116, which I’ve reopened and can be tackled first to unblock this one should MinVer be used.
It makes sense to switch to SDK style proj anyway since this is the new prefered format which comes with so much benefits like cleanliness, nuget packaging automation and more
Exactly my point! 😃 That’s because they are manually manage version and check it into the source code. It’s their choice to do it that way. And if one day they release incorrect version, it will be their responsibility. What we’ve done is we said “master is what’s released”. When a
releasebranch is merged intomasterwith all the changes (bug fixes, improvements, features), version is automatically updated and no human error can take place. Whatever is compiled locally - not maintainers responsibility. I do not see why it has to be…The assets you’re pointing to are a functionality of GitHub whenever a new release is created. Are you expecting any repository on GitHub to have a version embedded in the downloadable source attributed to a certain release? I’d say that’s unrealistic expectation and unnecessary.
Look at the ASB client. It has versioned releases and no version is embedded in the source code zip file. For that reason, I’m going to object adding info where it doesn’t belong. If someone wants a source w/o git info, they can download this zip. If someone wants a version, they have choco or release zip (top item in the list you referenced). Someone who wants to customize and run their own build, that’s their business.