pants: Using `pants` from `pantsup.sh` can fail with `FATAL: exception not rethrown`

Describe the bug

I upgraded a repo im working on to remove ./pants and add ./pantsup.sh, ran the new script and started using the pants it created.

Seemingly only in CI (github actions) it flakily fails with (for example):


✓ mypy succeeded.
FATAL: exception not rethrown
FATAL: exception not rethrown
/home/runner/work/_temp/f3725c23-b66e-48a4-b13a-9692347a0610.sh: line 1:  1684 Aborted                 (core dumped) ./scripts/pants check ::
Error: Process completed with exit code 134.

Pants version 2.14.1

OS Linux

Additional info

About this issue

Original URL
State: closed
Created a year ago
Comments: 27 (16 by maintainers)

Commits related to this issue

Shutdown all threads as part of Scheduler shutdown (#18166) As discussed in #16105, and further demonstrated in #18135: it is unsafe for threads to potentially be touching Python code while Python's ... — committed to pantsbuild/pants by stuhood a year ago
Shutdown all threads as part of Scheduler shutdown (#18166) As discussed in #16105, and further demonstrated in #18135: it is unsafe for threads to potentially be touching Python code while Python's ... — committed to benjyw/pants by stuhood a year ago
Shutdown all threads as part of Scheduler shutdown (#18166) As discussed in #16105, and further demonstrated in #18135: it is unsafe for threads to potentially be touching Python code while Python's ... — committed to stuhood/pants by stuhood a year ago
Shutdown all threads as part of Scheduler shutdown (Cherry-pick of #18166) (#18188) As discussed in #16105, and further demonstrated in #18135: it is unsafe for threads to potentially be touching Pyt... — committed to pantsbuild/pants by stuhood a year ago

Most upvoted comments

Hm, ok. John’s crash is different, because the reason pantsd is exiting in that case is a SIGTERM from a Pants client with a different fingerprint (it toggles between two Pants versions). I’ve opened #18159 to cover that one, as the signal handling aspect adds a new dimension that should make it much more rare.

I’ll try to get a patch out for this one first thing tomorrow, but @benjyw : if it has the shape I’m thinking it will, we probably will need to pick it to 2.15.x.

stuhood on Feb 2, 2023

FWIW this action lets you ssh into a github actions runner: https://github.com/marketplace/actions/debugging-with-ssh

benjyw on Feb 2, 2023

Even if there is a bug in your custom goal, I wouldn’t expect it to be able to fail so spectacularly, so presumably that just exposed a problem in the Pants engine. A problem that seems, however, to be fixed at https://github.com/pantsbuild/pants/commit/25f1cee6b5796f001e8f993b1c2b207eb673a6a4 …

benjyw on Feb 2, 2023