madge: Current `--circular` CLI is much slower than 0.6.0
v1.1.0
time ./node_modules/.bin/madge --circular src/app.js
No circular dependencies found!
real 0m24.876s
user 0m24.829s
sys 0m0.132s
v0.6.0
time ./node_modules/.bin/madge --format es6 --exclude=node_modules --circular src/app.js
No circular dependencies found!
real 0m0.298s
user 0m0.267s
sys 0m0.038s
I love this module btw, I have caught multiple circular dependencies using it, so thanks for all your work!
About this issue
- Original URL
- State: closed
- Created 8 years ago
- Comments: 18 (12 by maintainers)
@mrjoelkemp Think I’ve found an issue with the internal conversion of the tree from
dependency-treein madge that taking a long time to run is some cases. I’ll let you know when I’ve done some more profiling here …Yes, that’s really nice 😃 💃 Thanks for all your fixes lately that made this possible Joel.