pact_broker: Github Status checks are broken
Pre issue-raising checklist
I have already (please mark the applicable with an x):
- Upgraded to the latest Pact Broker OR
- Checked the CHANGELOG to see if the issue I am about to raise has been fixed
- Created an executable example that demonstrates the issue using either a:
- Dockerfile
- Git repository with a Travis or Appveyor (or similar) build
Software versions
- **pact-broker gem version: 1.33.0
- **pact-broker docker version: 2.76.0
- OS: e.g. Ubuntu
Expected behaviour
Github pending status checks need to be overwritten by success/failure on github pull requests
Actual behaviour
Github status checking both pending and success/failure status check for the pull requests
Steps to reproduce
- Give if have already had pact file generated from consumer , modify the pact file to add a new interaction or change an existing interaction
- Publish pacts to pact broker which will publish a pending status on the github PR
- After provider CI is complete, you will see a both status checks on the github PR
Relevant log files
We are not seeing any logs in the pact broker open-source on-premise hosted version

About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 22 (13 by maintainers)
Commits related to this issue
- chore: attempt to reproduce issue https://github.com/pact-foundation/pact_broker/issues/377 — committed to pact-foundation/pact_broker by bethesque 3 years ago
- chore: attempt to reproduce issue https://github.com/pact-foundation/pact_broker/issues/377 — committed to pact-foundation/pact_broker by bethesque 3 years ago
Ah - that will be because when the pending status is sent, we don’t know which provider branch is going to verify it. The contexts can never match. Take the provider tags out of the context and put it in the description.