pact-js-core: npm install should fail if download standalone fail

Software versions

  • OS: macOS 11.6
  • Pact Node version: v10.13.10
  • Node Version: v14.18.1
  • NPM Version: 8.1.0

Issue Checklist

Please confirm the following:

  • I have upgraded to the latest
  • I have the read the FAQs in the Readme
  • I have triple checked, that there are no unhandled promises in my code
  • I have set my log level to debug and attached a log file showing the complete request/response cycle
  • For bonus points and virtual high fives, I have created a reproduceable git repository (see below) to illustrate the problem

Expected behaviour

NPM Install should failed when failed to download standalone. This may be caused by network issue getting github assets or missing curl.

Actual behaviour

The installation was successful without any errors. The tar.gz file in node_modules/@pact-foundation/pact-node/standalone have zero size.

Relevant log files

    Error: spawn /node_modules/@pact-foundation/pact-node/standalone/linux-x64-1.88.77/pact/bin/pact-mock-service ENOENT

About this issue

  • Original URL
  • State: closed
  • Created 3 years ago
  • Comments: 18 (9 by maintainers)

Most upvoted comments

Closing as the latest version no longer downloads any artefacts on install.