oppia: [BUG]: Clicking on 'Set a Goal!' does nothing
Describe the bug
Clicking on ‘Set a Goal!’ does nothing in the skill progress tab when the browser view is set to half the screen size. The error seems to be happening in this element:
<a _ngcontent-xim-c7="" id="setting-a-goal-link" tabindex="0"><p _ngcontent-xim-c7="" class="empty-skill-proficiency">setting a goal! </p></a>
URL of the page where the issue is observed.
https://www.oppia.org/learner-dashboard
Steps To Reproduce
- Open the learner dashboard
- Go to the progress page
- Click on ‘Setting a Goal!’
Expected Behavior
I expect to be redirected to a webpage that shows my current goals, and an option to choose more goals. Which only happens once I open the window in full screen.
Screenshots/Videos
https://github.com/oppia/oppia/assets/112589278/f8e6a35a-b88b-494e-a10f-0864ac4e6f6d
What device are you using?
Desktop
Operating System
Windows
What browsers are you seeing the problem on?
Chrome
Browser version
No response
Additional context
No response
Tips for developers
Before tackling the bug, please use git bisect (see https://git-scm.com/docs/git-bisect) to investigate which PR caused it. If the issue occurred before commit https://github.com/oppia/oppia/commit/c7db0fe, the most effective approach is to utilize the Python setup for conducting a git bisect (You only need to go back as far as commit https://github.com/oppia/oppia/commits/9a334e9). If you need to perform a git bisect for any commit beyond that commit, the Docker setup will be suitable. If you find the PR, leave a comment on this issue pointing to it, or just say that it happened before commit 9a334e9 if you could reproduce it there. This will help us fix the issue by reverting the faulty PR.
Also, if this is your first issue, please make sure to follow https://github.com/oppia/oppia/wiki/Contributing-code-to-Oppia#choosing-a-good-first-issue and https://github.com/oppia/oppia/wiki/Contributing-code-to-Oppia#setting-things-up before claiming it. Thanks!
About this issue
- Original URL
- State: closed
- Created 6 months ago
- Comments: 32 (14 by maintainers)
Sure – if @sagar-subedi doesn’t open a PR within 24 hours, you can claim it instead. Thanks.
I have already opened a PR waiting approval from @kevintab95. #19405
Thanks.
@shagil77 Please start a conversation for the issue you’re facing in GitHub Discussions.
@sagar-subedi Per the guidance at https://github.com/oppia/oppia/wiki/Contributing-code-to-Oppia#choosing-a-good-first-issue, please provide an explanation of what your PR will do (with names of files you’re changing, what you plan to change in each file, etc.). Additionally it might be worth explaining what
[activeSubsection]="activeSubsection"does and whether or not it should be removed. If it looks good, we can assign you to this issue. Please also follow the other instructions on that wiki page if you have not yet done so. Thanks!Hi @satvshr @kanugurajesh @vaishnavi192 @kunal30114 @ayushjha119 @swiftanr @Aashish70 @sohamtembhurne @HardikGoyal2003 – thanks for trying to reproduce this. Could you please update your comments with a screencast showing whether it’s replicable or not replicable on your devices? That might help narrow down the root cause (e.g. screen width etc.).
Also, for those who can repro this, can you check if there are any console errors? Also maybe use right-click and Inspect Element to inspect the link and see what it points to. Please edit your comment to include this as part of your response.
Thanks!
yeah I also tried…It is working correctly…need some guidance to work on this issue
I have tried the same things you did it is working correctly for me
https://github.com/oppia/oppia/assets/120458029/37c410d1-290c-4801-9012-c0436c82325b