oppia-android: Tests Failing on Espresso in Landscape with small screen size or bug

Describe the bug After the migration to TextInputLayout, few test cases are failing on Espresso with small screen size.

Expected behavior All the test case should pass on multiple device screen size. Pixel, Pixel XL, Nexus 4, Tablet.

How to submit PR Add test result screenshot for Espresso and Robolectric on devices mentioned above.

Additional context


// possibly scrolling issue 
(@FareesHussain )
fun testAddProfileActivity_inputPin_inputDifferentConfirmPin_clickCreate_changeConfiguration_checkErrorMessageDisplayed() 

// possibly scrolling issue 
(@FareesHussain )
fun testAddProfileActivity_inputNotUniqueName_clickCreate_changeConfiguration_checkErrorMessageDisplayed()

// here, the error message is not displayed after orientation change. Need to investigate why this is passing earlier and why this is failing now. 
(@FareesHussain )
fun testProfileRenameActivity_inputOldName_clickSave_changeConfiguration_errorIsVisible() 

// Also confirm, can we update this layout file with using Neste Scroll View? 
(@prayutsu )
fun testAdminPinActivity_configurationChange_inputPin_inputWrongConfirmPin_clickImeActionButton_checkConfirmWrongError()

(@prayutsu )
fun testAdminPinActivity_inputPin_inputWrongConfirmPin_clickSubmit_configurationChange_checkConfirmWrongError()

(@prayutsu )
fun testAdminPinActivity_inputPin_inputWrongConfirmPin_clickImeActionButton_configurationChange_checkConfirmWrongError()

About this issue

  • Original URL
  • State: closed
  • Created 3 years ago
  • Comments: 17 (17 by maintainers)

Commits related to this issue

Most upvoted comments

Yup, so should I make a PR for AdminPinActivityTest?

@FareesHussain are you working on this? else you can assign to Abhay.

It’s fine then I’ll leave AdminPinActivity and make changes for all other activities