core: Network alias problem on 22.1.8

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug

After upgrade from 22.1.7 to 22.1.8 i have problem with network aliases type with added one entry, pfctl -t $ALIAS_NAME -T show returns 0 entries for this alias

To Reproduce

Steps to reproduce the behavior:

Add Alias type Network(s) with one entry (for example 10.10.0.0/24)
Reboot
Run pfctl -t test_aliast_one_net -T show to show entries

Screenshots Screenshot_20220525_211508

Expected behavior

pfctl -t test_aliast_one_net -T show return:

10.10.0.0/24

Environment

OPNsense 22.1.8 (amd64, OpenSSL).

About this issue

Original URL
State: closed
Created 2 years ago
Reactions: 5
Comments: 33 (11 by maintainers)

Links to this issue

Update to 22.1.8 broke 3 of the 5 networks?

Commits related to this issue

Firewall / Alias - when reading current alias content using pfctl, make sure to ignore empty lines. closes https://github.com/opnsense/core/issues/5788 (cherry picked from commit 021786612cae12fe7557... — committed to opnsense/core by AdSchellevis 2 years ago
Firewall/Alias - list_table returning empty ('') addresses. reintroduced https://github.com/opnsense/core/issues/5788 accidentally — committed to opnsense/core by AdSchellevis a year ago
Firewall/Alias - list_table returning empty ('') addresses. reintroduced https://github.com/opnsense/core/issues/5788 accidentally (cherry picked from commit e2dada5783e1fd86ec351f54897363c3b561390a)... — committed to opnsense/core by AdSchellevis a year ago

Most upvoted comments

I don’t normally complain on the internet but this is a pretty serious screw up. Perhaps you need to implement regression testing since this problem has happened before (22.1.8 and now 23.1.5)

If you want to throw wrenches either create a new ticket (this is off-topic) or open a PR with the work done.

Cheers, Franco

fichtner on Mar 29, 2023

@ALL highly annoying, it looks like I did reintroduce the same issue here https://github.com/opnsense/core/commit/e2dada5783e1fd86ec351f54897363c3b561390a .

can you try opnsense-patch e2dada5 to install this and reboot? on my end this seems to fix it.

AdSchellevis on Mar 29, 2023

Thank’s for having fix this quickly guys !..

Th4nat0s on May 26, 2022