openstack-exporter: Unexpected crash

Hello! Seems like i’ve found a little bug or something. I’ve installed openstack_exporter, open http://IP:9180, press on Metrics, it grabs some metrics and fails after some time:

19:42:51 openstack-exporter[26370]: time="2021-03-15T19:42:51+03:00" level=info msg="Collected metrics for exporter: openstack_neutron, metric: network_ip_availabilities
19:42:51 openstack-exporter[26370]: time="2021-03-15T19:42:51+03:00" level=info msg="Collected metrics for exporter: openstack_nova, metric: total_vms" source="exporter.
19:42:54 openstack-exporter[26370]: panic: runtime error: invalid memory address or nil pointer dereference
19:42:54 openstack-exporter[26370]: [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x8d50e6]
19:42:54 openstack-exporter[26370]: goroutine 58 [running]:
19:42:54 openstack-exporter[26370]: github.com/openstack-exporter/openstack-exporter/exporters.ListVolumes(0xc0003b5140, 0xc0003b5260, 0xf02c20, 0x2)
19:42:54 openstack-exporter[26370]:         /app/exporters/cinder.go:110 +0xca6
19:42:54 openstack-exporter[26370]: github.com/openstack-exporter/openstack-exporter/exporters.(*BaseOpenStackExporter).RunCollection(0xc0003b5140, 0xc0001eb310, 0xa505c
19:42:54 openstack-exporter[26370]:         /app/exporters/exporter.go:96 +0x20c
19:42:54 openstack-exporter[26370]: github.com/openstack-exporter/openstack-exporter/exporters.(*BaseOpenStackExporter).Collect(0xc0003b5140, 0xc0003b5260)
19:42:54 openstack-exporter[26370]:         /app/exporters/exporter.go:117 +0x101
19:42:54 openstack-exporter[26370]: github.com/prometheus/client_golang/prometheus.(*Registry).Gather.func1()
19:42:54 openstack-exporter[26370]:         /go/pkg/mod/github.com/prometheus/client_golang@v1.2.1/prometheus/registry.go:443 +0x19d
19:42:54 openstack-exporter[26370]: created by github.com/prometheus/client_golang/prometheus.(*Registry).Gather
19:42:54 openstack-exporter[26370]:         /go/pkg/mod/github.com/prometheus/client_golang@v1.2.1/prometheus/registry.go:535 +0xe12
19:42:54 systemd[1]: openstack-exporter.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
19:42:54 systemd[1]: openstack-exporter.service: Failed with result 'exit-code'.

So can’t load metrics. Command line usr/local/bin/openstack-exporter --os-client-config=/etc/exportercfg/openstack.yaml --disable-slow-metrics default

About this issue

Original URL
State: closed
Created 3 years ago
Comments: 16 (3 by maintainers)

Commits related to this issue

Verify that volume.attachments != nil Fixes #165 — committed to openstack-exporter/openstack-exporter by niedbalski 3 years ago
Verify that volume.attachments != nil (#167) Fixes #165 — committed to openstack-exporter/openstack-exporter by niedbalski 3 years ago
Verify that volume.attachments != nil (#167) Fixes #165 — committed to mzijdemans/openstack-exporter by niedbalski 3 years ago

Most upvoted comments

Hey @alexeymyltsev seems that this line https://github.com/openstack-exporter/openstack-exporter/commit/de1b6c26d42cc8e34e9e7b56ac03ecc61cc8acb0#diff-9e437cfda5b40a23adbafd857267fdf46bf34d1f53c0a69304980721b80bf42fR110

introduced a possible error, since attachments isn’t guaranteed to exists in older API(s), could you please add a volume.Attachments != nil && …

niedbalski on Mar 16, 2021