openssl: NPN / ALPN extensions callbacks don't allow handshake failure
The interface for the ALPN/NPN protocol selection callbacks and protocol selection notification callbacks do not allow for the handshake to fail. It is requested that the return value support for these methods be expanded to allow the handshake to fail. This may be desirable (and explicitly called out in the ALPN specification) in the event there are no common protocols found during the selection process, or if the select protocol is not acceptable.
For example:
ALPN RFC Section 3.2 specifies a new fatal alert definition no_application_protocol(120) which can be used. This is currently not defined in openssl.
The NPN specification is not as explicit about the alert to be used in this case but it could just result in a generic handshake_failure alert (if the callbacks return the new failure value)?
About this issue
- Original URL
- State: closed
- Created 10 years ago
- Comments: 15 (6 by maintainers)
Commits related to this issue
- Work around a known issue in OpenSSL (https://github.com/openssl/openssl/issues/188) that does not permit the TLS handshake to be failed if the ALPN negotiation fails. git-svn-id: https://svn.apache.... — committed to apache/tomcat by markt-asf 8 years ago
- Squashed 'vendor/liboqs/' changes from 04d7eaa..ff3986a ff3986a removed hard paths (#193) f62bb02 Enabled and documented building on ARM32 (Raspberry Pi). (#179) 9dab6f6 Flags for configured algorith... — committed to christianpaquin/openssl by christianpaquin 7 years ago
@richsalz did this ever land in openssl ? I am trying to find the changeset but no luck so far 😕