openssl: Inconsistent generation logic for asm modules

In commits 10eab320a5e4b585f640b5f11d21eebaebb1814a, 184bc45f683c76531d7e065b6553ca9086564576 and eb77e8886df84526f42f566632be71d4ed373308 and perhaps other commits most of the assembly modules were modified to take an output file name. But apparently not all. NetBSD does cross-builds and needs to generate the Perl asm files directly bypassing Configure. It would be good to have the logic be consistent across all architectures.

Still writing to STDOUT:

crypto/des/asm/desboth.pl
crypto/rc4/asm/rc4-c64xplus.pl
crypto/sha/asm/keccak1600-armv4.pl
crypto/sha/asm/keccak1600-avx2.pl
crypto/sha/asm/keccak1600-avx512.pl
crypto/sha/asm/keccak1600-avx512vl.pl
crypto/sha/asm/keccak1600-c64x.pl

About this issue

Original URL
State: closed
Created 6 years ago
Comments: 40 (31 by maintainers)

Commits related to this issue

Make a few more asm modules conform: last argument is output file Fixes #5310 — committed to levitte/openssl by levitte 6 years ago
Make a few more asm modules conform: last argument is output file Fixes #5310 — committed to levitte/openssl by levitte 6 years ago
Make a few more asm modules conform: last argument is output file Fixes #5310 Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5316) — committed to openssl/openssl by levitte 6 years ago
Make a few more asm modules conform: last argument is output file Fixes #5310 Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5316) — committed to makr/openssl by levitte 6 years ago

Most upvoted comments

The reason we cannot use Configure or build the assembly files every time is because we don’t distribute perl in the base software.

zoulasc on Feb 12, 2018