openssl: Builds broken in 3.3.0 in conf-lib.c

The following compile errors occur because conf-lib.c incorrectly defines _XOPEN_SOURCE_EXTENDED. This define must be set to 1 if specified. Platforms that already specify this #define break and cannot compile.

 #define _XOPEN_SOURCE_EXTENDED   /* To get a definition of strdup() */
          ^
"/home/jenkinsbuild/.jenkins/workspace/OpenSSL-3.3_Pipeline/crypto/conf/conf_lib.c", line 10: warning(140):
          macro redefined differently

  #if _XOPEN_SOURCE_EXTENDED == 1
                             ^

This is a critical breakage and stops OpenSSL from compiling.

About this issue

Original URL
State: closed
Created 3 months ago
Comments: 21 (19 by maintainers)

Commits related to this issue

VMS: Move defining _XOPEN_SOURCE and _XOPEN_SOURCE_EXTENDED to config target For all other platforms that need these macros defined, that's how it's done, so we have VMS follow suit. That avoids a ... — committed to levitte/openssl by levitte 3 months ago
VMS: Move defining _XOPEN_SOURCE and _XOPEN_SOURCE_EXTENDED to config target For all other platforms that need these macros defined, that's how it's done, so we have VMS follow suit. That avoids a ... — committed to openssl/openssl by levitte 3 months ago
VMS: Move defining _XOPEN_SOURCE and _XOPEN_SOURCE_EXTENDED to config target For all other platforms that need these macros defined, that's how it's done, so we have VMS follow suit. That avoids a ... — committed to maximmasiutin/openssl by levitte 3 months ago

Most upvoted comments

@t8m do we maintain a canonical list of community maintainers which we can use for that?

Yes, there is the list at https://www.openssl.org/policies/general-supplemental/platforms.html (although I am not Tomáš!)

tom-cosgrove-arm on Apr 10, 2024

There can be a lot of merges from time to time. IMO doing a CI run once or twice day would be sufficient.

@t8m The poll is scheduled between 2am and 3am daily. That should work.

rsbeckerca on Apr 11, 2024

I’ve updated https://github.com/openssl/tools/blob/master/HOWTO-make-a-release.md to rmind us to notify community platform owners of impending freeze dates

nhorman on Apr 10, 2024

I wonder if it would be beneficial, when we freeze the tree for a release (alpha/beta/final) that, in addition to emailing the comitters list, we also cc the community platform maintainers, indicating that during these freeze periods that target release branches should undergo additional community ci (daily build/test, etc) to help ensure changes admitted during freeze dont have adverse effects on those community platforms.

@t8m do we maintain a canonical list of community maintainers which we can use for that?

nhorman on Apr 9, 2024