openseadragon: Duplicate IDs in overlay HTML

$.Overlay newly adds a wrapper element with an id attribute to each overlay element, but if the element does not have an id (which is not mandatory), multiple overlays share the same id, leading to invalid HTML.

https://github.com/openseadragon/openseadragon/blob/2387c3afd5a89800be78ff8d2d7f0e91fe63e821/src/overlay.js#L135-L139.

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 17 (10 by maintainers)

Commits related to this issue

Most upvoted comments

Hi @iangilman

I believe I have resolved the issue in Pull Request #2698. When you get a chance, could you please review it and let me know if any further improvements are needed?

Looking forward to your feedback.

Thanks!

Well yes, we definitely need to not continue to have the duplicated ids. I was just thinking about keeping the id that includes the wrapped element’s id, since that will be unique.