openhab-core: [MDNSDiscoveryService] potential bug deleting items from Inbox??

I have been developing a binding that implements a MDNSDiscoveryParticipant to discover the bridge. One user reports that every time the participant add such a bridge to the Inbox, the core then deletes it again. I think this could be a bug in the MDNSDiscoveryService class…

the method removeOlderResults() method seems to be called, but it is not clear why.
and also timestampOfLastScan seems not to be being initialized.

public class MDNSDiscoveryService extends AbstractDiscoveryService implements ServiceListener {
..
    protected synchronized void stopScan() {
        removeOlderResults(getTimestampOfLastScan());
        super.stopScan();
    }

About this issue

Original URL
State: closed
Created 4 years ago
Comments: 16 (16 by maintainers)

Most upvoted comments

@jlaur if you are happy with this, then I will open a PR (actually two, one for the core, and one for the binding)…

andrewfg on Dec 20, 2021

@jlaur the final release of OH v3.2.x means that the maintainers updated the build system to OH v3.3.x so if you want to test things, you will need a spare PC running v3.3.x-SNAPSHOT

If you have such a system then HERE you will find two JAR files as follows…

org.openhab.core.config.discovery.mdns-3.3.0-SNAPSHOT.jar - this adds support for a grace period to the OH core
org.openhab.binding.miele-3.3.0-SNAPSHOT.jar - this adds support for the above to the Miele binding

You need a system running OH v3.3.x and you need to add those two JARs to the ‘addons’ folder. And you may also need to open the openhab console and bundle:uninstall the prior org.openhab.core.config.discovery.mdns jar resp. bundle:install the new version…

andrewfg on Dec 20, 2021

I’m thinking the same logic about grace periods…

andrewfg on Jan 25, 2021