openhab-android: Frame visibility in sitemap ignored
PR #1174 looks to be included in 2.7.10-beta, so it may have caused this, or it isn’t included and may fix this issue.
Actual behaviour
Sitemaps with items that should be hidden are always visible. Basic UI displays them properly.
Expected behaviour
Sitemaps with items that should be hidden should be hidden.
Steps to reproduce
- Add Item1 to a sitemap inside a frame with visibility based on Item2.
- Toggle Item2 and notice visibility of Item1 does not change.
Here is a snip from the sitemap where I see this occurring…
Frame visibility=[Mode=="Morning"] {
Switch item=Wakeup_Alarm
Switch item=Wakeup_Alarm_Snooze
}
Environment data
Client
- Android version: 2.7.10-beta
Server
- Server version: S1627
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Comments: 21 (12 by maintainers)
Commits related to this issue
- Correctly handle SSE events without item. (#1466) The code already was prepared for this by allowing passing null as item, we just need to use the correct JSON parser method that doesn't throw an e... — committed to openhab/openhab-android by maniac103 5 years ago
- Fix handling of frames without label. We shouldn't simply filter them, as doing so - produces wrong visual output (no spacer) - creates issues when visibility of that frame is changed Instead, just ... — committed to maniac103/openhab.android by maniac103 5 years ago
- Fix handling of frames without label. (#1502) * Fix handling of frames without label. We shouldn't simply filter them, as doing so - produces wrong visual output (no spacer) - creates issues whe... — committed to openhab/openhab-android by maniac103 5 years ago
I think so, yes.