openhab-addons: Proper closing of WebSockets to avoid memory leak / crash
It was recently discovered 2 bindings not correctly closing WebSockets. This leads to memory leak and even openHAB crash. I think it would be good to check that all bindings using WebSockets are correctly closing WebSockets.
I found 12 bindings using WebSockets:
- amazonechocontrol (PR #7919, PR #8074)
- bosesoundtouch (PR #8031, PR #8073)
- deconz (uses
get()on connect) - innogysmarthome (PR #8080)
- kodi (PR #8030)
- lgwebos (PR #8038)
- loxone (PR #8032 closed, PR #8154 closed)
- samsungtv (PR #8025, PR #8072)
- sonyaudio (uses
get()on connect) - tibber (PR #8033, PR #8071)
- valloxmv (PR #8035)
- vektiva (uses
get()on connect)
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Comments: 27 (27 by maintainers)
Commits related to this issue
- [lgwebos] Improved WebSocket reconnect/disconnect Related to #8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr> — committed to lolodomo/openhab-addons by lolodomo 4 years ago
- [tibber] Partial revert of PR 8033 Related to #8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr> — committed to lolodomo/openhab-addons by lolodomo 4 years ago
- [samsungtv] Partial revert of PR 8025 Related to #8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr> — committed to lolodomo/openhab-addons by lolodomo 4 years ago
- [bosesoundtouch] Partial revert of PR 8031 Related to #8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr> — committed to lolodomo/openhab-addons by lolodomo 4 years ago
- [amazonechocontrol] Partial revert of PR 7919 Related to #8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr> — committed to lolodomo/openhab-addons by lolodomo 4 years ago
- [innogysmarthome] Fix possible resource leak Related to #8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr> — committed to lolodomo/openhab-addons by lolodomo 4 years ago
- [innogysmarthome] Fix possible resource leak Related to #8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr> — committed to lolodomo/openhab-addons by lolodomo 4 years ago
- [innogysmarthome] Fix possible resource leak Related to #8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr> — committed to lolodomo/openhab-addons by lolodomo 4 years ago
- [innogysmarthome] Fix possible resource leak (#8080) Related to #8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr> — committed to openhab/openhab-addons by lolodomo 4 years ago
- [innogysmarthome] Fix possible resource leak (#8080) Related to #8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr> — committed to knikhilwiz/openhab2-addons by lolodomo 4 years ago
- [bosesoundtouch] Partial revert of PR 8031 (#8073) Related to #8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr> — committed to openhab/openhab-addons by lolodomo 4 years ago
- [tibber] Partial revert of PR 8033 Related to #8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr> — committed to lolodomo/openhab-addons by lolodomo 4 years ago
- [lgwebos] Improved WebSocket reconnect/disconnect (#8038) Related to #8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr> — committed to openhab/openhab-addons by lolodomo 4 years ago
- [tibber] Partial revert of PR 8033 (#8071) Related to #8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr> — committed to openhab/openhab-addons by lolodomo 4 years ago
- [loxone] Fix possible resource leak Replace #8032 Related to #8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr> — committed to lolodomo/openhab-addons by lolodomo 4 years ago
- [amazonechocontrol] Partial revert of PR 7919 (#8074) Related to #8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr> — committed to openhab/openhab-addons by lolodomo 4 years ago
- [innogysmarthome] Fix possible resource leak (#8080) Related to #8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: CSchlipp <christian@schlipp.de> — committed to CSchlipp/openhab-addons by lolodomo 4 years ago
- [bosesoundtouch] Partial revert of PR 8031 (#8073) Related to #8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: CSchlipp <christian@schlipp.de> — committed to CSchlipp/openhab-addons by lolodomo 4 years ago
- [lgwebos] Improved WebSocket reconnect/disconnect (#8038) Related to #8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: CSchlipp <christian@schlipp.de> — committed to CSchlipp/openhab-addons by lolodomo 4 years ago
- [tibber] Partial revert of PR 8033 (#8071) Related to #8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: CSchlipp <christian@schlipp.de> — committed to CSchlipp/openhab-addons by lolodomo 4 years ago
As I mentioned earlier, I believe there is a risk in case the connection retry would occur more frequently than the connect timeout. For the LGwebOS binding, if the connect timeout is set to 1s, there is no risk. By the way, handling the connection future cannot be a wrong thing.