openhab-addons: OH3: Maven build failing (bad format violations in a POM)
Even using -DskipChecks does not help avoiding this blocking step.
Is there a way to disable this check ?
[INFO] --- spotless-maven-plugin:2.0.3:check (codestyle_check) @ org.openhab.addons.reactor.bundles ---
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] openHAB Add-ons .................................... SUCCESS [03:12 min]
[INFO] openHAB Add-ons :: BOM ............................. SUCCESS [ 0.062 s]
[INFO] openHAB Add-ons :: BOM :: Runtime Index ............ SUCCESS [03:07 min]
[INFO] openHAB Add-ons :: BOM :: Test Index ............... SUCCESS [ 22.930 s]
[INFO] openHAB Add-ons :: BOM :: openHAB Core Index ....... SUCCESS [01:54 min]
[INFO] openHAB Add-ons :: Bundles ......................... FAILURE [ 37.950 s]
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 10:23 min
[INFO] Finished at: 2020-10-10T13:21:45+02:00
[INFO] Final Memory: 135M/512M
[INFO] ------------------------------------------------------------------------
[INFO] Static code analysis summary report is available in:
[INFO] file:/D:/dev/openhab2/git/openhab-addons/target/summary_report.html
[ERROR] Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.0.3:check (codestyle_check) on project org.openhab.addons.reactor.bundles: The following files had format violations:
[ERROR] pom.xml
[ERROR] @@ -1,554 +1,554 @@
[ERROR] -<?xml version="1.0" encoding="UTF-8" standalone="no"?>\r\n
[ERROR] -<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"\r\n
[ERROR] - xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">\r\n
[ERROR] -\r\n
[ERROR] - <modelVersion>4.0.0</modelVersion>\r\n
[ERROR] -\r\n
[ERROR] - <parent>\r\n
[ERROR] - <groupId>org.openhab.addons</groupId>\r\n
[ERROR] - <artifactId>org.openhab.addons.reactor</artifactId>\r\n
[ERROR] - <version>3.0.0-SNAPSHOT</version>\r\n
[ERROR] - </parent>\r\n
[ERROR] -\r\n
[ERROR] - <groupId>org.openhab.addons.bundles</groupId>\r\n
[ERROR] - <artifactId>org.openhab.addons.reactor.bundles</artifactId>\r\n
[ERROR] - <packaging>pom</packaging>\r\n
[ERROR] -\r\n
[ERROR] - <name>openHAB Add-ons :: Bundles</name>\r\n
[ERROR] -\r\n
[ERROR] - <modules>\r\n
[ERROR] - <!-- io -->\r\n
[ERROR] - <module>org.openhab.io.homekit</module>\r\n
[ERROR] - <module>org.openhab.io.hueemulation</module>\r\n
[ERROR] - <module>org.openhab.io.imperihome</module>\r\n
[ERROR] - <module>org.openhab.io.neeo</module>\r\n
[ERROR] - <module>org.openhab.io.openhabcloud</module>\r\n
[ERROR] - <module>org.openhab.io.transport.modbus</module>\r\n
[ERROR] - <!-- transformations -->\r\n
[ERROR] - <module>org.openhab.transform.bin2json</module>\r\n
[ERROR] - <module>org.openhab.transform.exec</module>\r\n
[ERROR] - <module>org.openhab.transform.javascript</module>\r\n
[ERROR] - <module>org.openhab.transform.jinja</module>\r\n
[ERROR] - <module>org.openhab.transform.jsonpath</module>\r\n
[ERROR] - <module>org.openhab.transform.map</module>\r\n
[ERROR] - <module>org.openhab.transform.regex</module>\r\n
[ERROR] - <module>org.openhab.transform.scale</module>\r\n
[ERROR] - <module>org.openhab.transform.xpath</module>\r\n
[ERROR] - <module>org.openhab.transform.xslt</module>\r\n
[ERROR] - <!-- bindings -->\r\n
[ERROR] - <module>org.openhab.binding.adorne</module>\r\n
[ERROR] - <module>org.openhab.binding.airquality</module>\r\n
[ERROR] - <module>org.openhab.binding.airvisualnode</module>\r\n
[ERROR] - <module>org.openhab.binding.alarmdecoder</module>\r\n
[ERROR] - <module>org.openhab.binding.allplay</module>\r\n
[ERROR] - <module>org.openhab.binding.amazondashbutton</module>\r\n
[ERROR] - <module>org.openhab.binding.amazonechocontrol</module>\r\n
[ERROR] - <module>org.openhab.binding.ambientweather</module>\r\n
[ERROR] - <module>org.openhab.binding.astro</module>\r\n
[ERROR] - <module>org.openhab.binding.atlona</module>\r\n
[ERROR] ... (1060 more lines that didn't fit)
[ERROR] Run 'mvn spotless:apply' to fix these violations.
```About this issue
- Original URL
- State: closed
- Created 4 years ago
- Comments: 35 (34 by maintainers)
Commits related to this issue
- Add .gitattributes Without this configuration there are issues with line endings on Windows. See: openhab/openhab-addons#8712 Signed-off-by: Wouter Born <github@maindrain.net> — committed to wborn/openhab-addons by wborn 4 years ago
- Add .gitattributes Without this configuration there are Spotless issues with line endings on Windows. See: openhab/openhab-addons#8712 Signed-off-by: Wouter Born <github@maindrain.net> — committed to wborn/openhab-core by wborn 4 years ago
- Add .gitattributes (#8874) Without this configuration there are issues with line endings on Windows. See: openhab/openhab-addons#8712 Signed-off-by: Wouter Born <github@maindrain.net> — committed to openhab/openhab-addons by wborn 4 years ago
- Add .gitattributes Without this configuration there are Spotless issues with line endings on Windows. See: openhab/openhab-addons#8712 Signed-off-by: Wouter Born <github@maindrain.net> — committed to wborn/openhab-webui by wborn 4 years ago
- Add .gitattributes Without this configuration there are Spotless issues with line endings on Windows. See: openhab/openhab-addons#8712 Signed-off-by: Wouter Born <github@maindrain.net> — committed to wborn/static-code-analysis by wborn 4 years ago
- Add .gitattributes (#1767) Without this configuration there are Spotless issues with line endings on Windows. See: openhab/openhab-addons#8712 Signed-off-by: Wouter Born <github@maindrain.net> — committed to openhab/openhab-core by wborn 4 years ago
- Add .gitattributes (#458) Without this configuration there are Spotless issues with line endings on Windows. See: openhab/openhab-addons#8712 Signed-off-by: Wouter Born <github@maindrain.net> — committed to openhab/openhab-webui by wborn 4 years ago
- Add .gitattributes (#397) Without this configuration there are Spotless issues with line endings on Windows. See: openhab/openhab-addons#8712 Signed-off-by: Wouter Born <github@maindrain.net> — committed to openhab/static-code-analysis by wborn 4 years ago
- Add .gitattributes (#8874) Without this configuration there are issues with line endings on Windows. See: openhab/openhab-addons#8712 — committed to nowaterman/openhab-addons by wborn 4 years ago
- Add .gitattributes (#8874) Without this configuration there are issues with line endings on Windows. See: openhab/openhab-addons#8712 Signed-off-by: Wouter Born <github@maindrain.net> — committed to boehan/openhab-addons by wborn 4 years ago
- Add .gitattributes (#8874) Without this configuration there are issues with line endings on Windows. See: openhab/openhab-addons#8712 Signed-off-by: Wouter Born <github@maindrain.net> — committed to marcfischerboschio/openHABaddon by wborn 4 years ago
Check bypassed if I use the following command:
mvn clean install -Dspotless.check.skip=truewithout the “”This is probably something to add in the documentation in addtion to
-DskipChecksand-DskipTests.It solves the problem for me 😃
It might cause Spotless to think you prefer Unix-like line endings while Git thinks you prefer DOS/Windows line endings.
See also the Spotless line endings documentation:
The only increase in build times I have noticed is due to more add-ons having been merged recently. I added some more options to the README that you can use to improve build times in https://github.com/openhab/openhab-addons/pull/8767.
Try disabling feature verification and a parallel build, e.g.:
mvn clean install -DskipChecks=true -DskipTests=true -Dfeatures.verify.skip=true -Dspotless.check.skip=true -T 1CWith that it only takes ~1 minute to build all add-ons on my machine.