openapi-generator: typescript-node generates invalid typescript

Bug Report Checklist

• Have you provided a full/minimal spec to reproduce the issue?
• Have you validated the input using an OpenAPI validator (example)?
• What’s the version of OpenAPI Generator used?
• Have you search for related issues/PRs?
• What’s the actual output vs expected output?
• [Optional] Bounty to sponsor the fix (example)

Description

Using a valid swagger JSON I generated a client using the following command:

openapi-generator  generate -i the.json -l typescript-node

The resulting code is invalid Typescript and cannot be transpiled without manual intervention:

import Promise = require('bluebird');

The above line is completely redundant in Typescript. There is no requirement to use bluebird as promises are part of the basic node offering.

import { ObjectSerializer, Authentication, HttpBasicAuth, ApiKeyAuth, OAuth, VoidAuth } from '../model/models';

error TS6133: ‘HttpBasicAuth’ is declared but its value is never read. error TS6133: ‘ApiKeyAuth’ is declared but its value is never read. error TS6133: ‘OAuth’ is declared but its value is never read.

Apart from the errors themselves, it is concerning that no oauth authentication is included in the authentications property.

Asynchronous methods (those that return a Promise) should be declared as async methods. For example, this:

public calculateLine (calculateLineRequest: CalculateLineRequest) : Promise<{ response: http.ClientResponse; body: CalculateLineResponse;  }>

should be

public async calculateLine (calculateLineRequest: CalculateLineRequest) : Promise<{ response: http.ClientResponse; body: CalculateLineResponse;  }>

otherwise typescript consumers of the API cannot use await when calling the API method.

openapi-generator version

3.3.4

OpenAPI declaration file content or url

I cannot provide this as it a private commercial API

Command line used for generation

openapi-generator  generate -i the.json -l typescript-node

Steps to reproduce

Just generate the code

Related issues/PRs

Suggest a fix

Drop the reference to bluebird. Declare asynchronous methods as async Investigate why there is no oauth authentication